Skip to content

Conversation

@xunma
Copy link
Collaborator

@xunma xunma commented Sep 17, 2025

Summary

This PR updates the .pochi/workflows/create-pr.md file to include more detailed instructions for creating a pull request.

Specifically, it adds:

  • A guideline to ask for an issue number if one is not provided.
  • A clarification to write a meaningful PR description, in addition to the title and commit message.

🤖 Generated with Pochi

@xunma
Copy link
Collaborator Author

xunma commented Sep 17, 2025

Result

This is how it works when:

@xunma xunma requested a review from wsxiaoys September 17, 2025 05:42
@@ -1,7 +1,8 @@
Please help create a PR for the current staging changes, following these guidelines:
- If an issue number is not provided, use askFollowupQuestion to ask for it. If user provides a valid issue number, link to the issue with `Resolves <ISSUE_NUMBER>` at the beginning of the PR description.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give an option of askFollowUpQuestion that help user find the issue. (have issue / no issue / find issue for me)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wsxiaoys nice suggestion. it works well 👉 https://app.getpochi.com/tasks/jUcSdiIW

only minor thing is, when user select find issue for me, the output by default is collapsed — user needs to manually open it to see the full issue list. I think it wouldn't be a big issue, as the user of this workflow should know they can open the list..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can optimize prompt to make it generates better output and confirm it with user.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wsxiaoys okie! I specified the output format(not sure if I am being too specific here...)

When choosing find issue for me:

@xunma xunma changed the title docs: Update create-pr.md workflow instructions workflows: Update create-pr.md workflow instructions Sep 17, 2025
@xunma xunma force-pushed the docs/update-create-pr-workflow branch from f968b1d to 05f86db Compare September 17, 2025 06:15
@xunma xunma requested a review from wsxiaoys September 17, 2025 06:16
@xunma xunma changed the title workflows: Update create-pr.md workflow instructions feat(workflows): Update create-pr.md workflow instructions Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants