-
Notifications
You must be signed in to change notification settings - Fork 666
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SECURITY] Avoid creation of backend users without password
When using FormEngine it is possible to create a Backend User without setting a password (or username), which could lead to issues when using third-party authentication providers. A hook within DataHandler ensures to set a random username and/or password if the data is handed into DataHandler without proper data. Besides that new backend users are disabled per default and have to be enable manually. Resolves: #80269 Releases: master, 9.5, 8.7 Security-Commit: c019928c25cf8d94e68f9ae7f7edf7251cb4f535 Security-Bulletin: TYPO3-CORE-SA-2019-002 Change-Id: I35c18271f3650c0d9303e736fd7f26a9ad813e4a Reviewed-on: https://review.typo3.org/59528 Reviewed-by: Oliver Hader <oliver.hader@typo3.org> Tested-by: Oliver Hader <oliver.hader@typo3.org>
- Loading branch information
Showing
3 changed files
with
73 additions
and
4 deletions.
There are no files selected for viewing
67 changes: 67 additions & 0 deletions
67
typo3/sysext/core/Classes/Hooks/BackendUserPasswordCheck.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| <?php | ||
| declare(strict_types = 1); | ||
|
|
||
| namespace TYPO3\CMS\Core\Hooks; | ||
|
|
||
| /* | ||
| * This file is part of the TYPO3 CMS project. | ||
| * | ||
| * It is free software; you can redistribute it and/or modify it under | ||
| * the terms of the GNU General Public License, either version 2 | ||
| * of the License, or any later version. | ||
| * | ||
| * For the full copyright and license information, please read the | ||
| * LICENSE.txt file that was distributed with this source code. | ||
| * | ||
| * The TYPO3 project - inspiring people to share! | ||
| */ | ||
|
|
||
| use TYPO3\CMS\Core\Crypto\Random; | ||
| use TYPO3\CMS\Core\DataHandling\DataHandler; | ||
| use TYPO3\CMS\Core\Utility\GeneralUtility; | ||
| use TYPO3\CMS\Core\Utility\MathUtility; | ||
|
|
||
| /** | ||
| * DataHandler hook to ensure that a be_user always has a username + password set if newly-created. | ||
| * | ||
| * @internal This class is a hook implementation and is not part of the TYPO3 Core API. | ||
| */ | ||
| class BackendUserPasswordCheck | ||
| { | ||
| /** | ||
| * @var Random | ||
| */ | ||
| protected $random; | ||
|
|
||
| public function __construct() | ||
| { | ||
| $this->random = GeneralUtility::makeInstance(Random::class); | ||
| } | ||
|
|
||
| /** | ||
| * @param array $incomingFieldArray | ||
| * @param string $table | ||
| * @param string $id | ||
| * @param DataHandler $dataHandler | ||
| */ | ||
| public function processDatamap_preProcessFieldArray(&$incomingFieldArray, $table, $id, DataHandler $dataHandler) | ||
| { | ||
| // Not within be_users | ||
| if ($table !== 'be_users') { | ||
| return; | ||
| } | ||
| // Existing record, nothing to change | ||
| if (MathUtility::canBeInterpretedAsInteger($id)) { | ||
| return; | ||
| } | ||
| if ($dataHandler->isImporting) { | ||
| return; | ||
| } | ||
| if (!isset($incomingFieldArray['password']) || (string)$incomingFieldArray['password'] === '') { | ||
| $incomingFieldArray['password'] = GeneralUtility::hmac($id, $this->random->generateRandomBytes(20)); | ||
| } | ||
| if (!isset($incomingFieldArray['username']) || (string)$incomingFieldArray['username'] === '') { | ||
| $incomingFieldArray['username'] = 'autogenerated-' . GeneralUtility::shortMD5($id); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters