Error in 2.7.3 at flow:package:rescan

[patriceckhart]

Version: 2.7.3

When I run the flow flow:package:rescan I get the following error. The error does not occur with version 2.7.2.

Error:
Warning: Undefined variable $argv in /data/neos/Packages/Libraries/typo3fluid/fluid/src/Tools/console.php line 22

[booooza]

Same here

[fcool]

Sadly this is no bug in typo3fluid but a bug (or missing feature) in Flow's Object-Management.

It seems like enabling the Object-Management for typo3fluid is not necessary at all. At least in one project I testet it was sufficient to disable it for typo3fluid like that in Flow's Settings.yaml:

Neos:
  Flow:
    object:
      includeClasses:
        'typo3fluid.fluid': []

Flow's object management makes a lot of assumptions about included classes and typo3fluid now breaks some of them (this bug here results from including in not global context by the proxy builder, another one would be the "console.php" not following PSR-4 (which is a bug in typo3fluid, too... :P )

[mbrodala]

Thanks for the investigation and workaround/fix.

[paavo]

Mh, why is this already closed? 🤔

[fcool]

Because this is not to fix by typo3fluid/fluid - it has to be fixed in neos/flow-development-collection

The only thing fluid "could" fix is the PSR-4 violation, but that would not solve the error reported here ;)

[lolli42]

Would it help flow to merge the content from console.php back into bin/fluid and remove console.php again? Guess that wouldn't hurt much and if it simplifies flow's life, it shouldn't be too hard to do and release as 2.7.4?

[kdambekalns]

Would it help flow to merge the content from console.php back into bin/fluid and remove console.php again?

Yes, that would help. Flow tries to parse console.php as a class file, and fails (since that file directly "runs" when being included, something we don't expect in a folder supposed to contain classes.) So if the file disappeared, that would solve our issue.

[kdambekalns]

Our workaround would (for now) be neos/flow-development-collection#2994 – with the drawback of breaking XSD schema generation (but I have no clue how many people use that.)

[lolli42]

ok. if anyone could create a PR in this regard already, it would be great. otherwise i'll pick up tomorrow.