[TASK] Sanitise Fluid integration #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the Fluid integration in the following ways: * Adds an extension key context variable to AbstractWidget which allows a third-party widget to override the use of "dashboard" as extension key without having to override the initializeView method. * Uses this extension key to prefill the TemplatePaths used by the created view. * Renames the template folders to observe the usual MVC pattern used by Fluid in TYPO3 CMS and not require non-standard template root paths. * Renames the Layout to not require non-standard layout root paths.
|
Requires rebase and adaptation of one additional template file if #69 is merged first. |
haassie
approved these changes
Oct 21, 2019
NamelessCoder
added a commit
to NamelessCoder/dashboard
that referenced
this pull request
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the Fluid integration in the following ways:
which allows a third-party widget to override the use
of "dashboard" as extension key without having to override
the initializeView method.
by the created view.
pattern used by Fluid in TYPO3 CMS and not require
non-standard template root paths.
root paths.