Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Index.rst #4866

Closed
wants to merge 1 commit into from
Closed

Conversation

conpassione
Copy link

Public directory in Example changed from "web" to "public" for more consitency from text to example.

Public directory in Example changed from "web" to "public" for more consitency from text to example.
Copy link
Contributor

@brotkrueml brotkrueml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request.

However, the default value is "public":
https://github.com/TYPO3/CmsComposerInstallers?tab=readme-ov-file#web-dir

The code snippet is about how to change it to another folder. That's why I suggest to keep the current state and not change it.

@conpassione
Copy link
Author

conpassione commented Oct 19, 2024 via email

@brotkrueml
Copy link
Contributor

@conpassione No problem :-)

Therefore, closing it.

@brotkrueml brotkrueml closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants