Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description is not readable when not diffing #54

Closed
TWiStErRob opened this issue Dec 25, 2023 · 1 comment · Fixed by #181
Closed

Description is not readable when not diffing #54

TWiStErRob opened this issue Dec 25, 2023 · 1 comment · Fixed by #181
Labels
bug Something isn't working
Milestone

Comments

@TWiStErRob
Copy link
Owner

image

@TWiStErRob TWiStErRob added the bug Something isn't working label Dec 25, 2023
@TWiStErRob
Copy link
Owner Author

TWiStErRob commented Dec 25, 2023

Index: web/status-history/src/main/resources/views/LineStatus.hbs
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/web/status-history/src/main/resources/views/LineStatus.hbs b/web/status-history/src/main/resources/views/LineStatus.hbs
--- a/web/status-history/src/main/resources/views/LineStatus.hbs	(revision 7b747b87fa0ca90d3af0708efa27d4ad78be67c7)
+++ b/web/status-history/src/main/resources/views/LineStatus.hbs	(date 1703548313466)
@@ -100,14 +100,21 @@
 			<tr>
 				<td class="line-{{lineStatus.line}}">{{lineStatus.line.title}}</td>
 				<td class="delay {{changeStatus.cssClass}} {{delayStyle}}">
-					{{#if (or (empty lineStatus.description) (empty lineStatus.branchDescription))}}
-						{{lineStatus.type.title}}
-					{{else}}
+					{{#if (or (not (empty lineStatus.description)) (not (empty lineStatus.branchDescription)))}}
 						<a rel="htmltooltip">{{lineStatus.type.title}}</a>
 						<div class="htmltooltip">
-							<p>{{lineStatus.description}}</p>
-							<p>{{lineStatus.branchDescription}}</p>
+							{{#if (not (empty lineStatus.description))}}
+								<span>{{lineStatus.description}}</span>
+							{{/if}}
+							{{#if (and (not (empty lineStatus.description)) (not (empty lineStatus.branchDescription)))}}
+								<br/><br/>
+							{{/if}}
+							{{#if (not (empty lineStatus.branchDescription))}}
+								<span>{{lineStatus.branchDescription}}</span>
+							{{/if}}
 						</div>
+					{{else}}
+						{{lineStatus.type.title}}
 					{{/if}}
 				</td>
 				<td class="change {{changeStatus.cssClass}}">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant