Skip to content

WIP: Remove .tvpp files (all player data stored in database) - #18

Draft
gesior wants to merge 4 commits into
TVPV8:mainfrom
gesior:no-tvpp
Draft

WIP: Remove .tvpp files (all player data stored in database)#18
gesior wants to merge 4 commits into
TVPV8:mainfrom
gesior:no-tvpp

Conversation

@gesior

@gesior gesior commented Feb 12, 2026

Copy link
Copy Markdown
Collaborator

Work in progress

Mostly AI generated. I did some tests and code fixes, to make it work more like OTS (not like AI hallucinated it).

Just tested player login/logout and basic EQ save.
Not tested yet: depot items [check different towns], storages [string and number], item attributes (of equipped EQ), vip lists, conditions, blessings, capacity and unjust kills.

Database migration adds save column in table players that is not used by OTS, but it's required by MyAAC to install.

Someone requested this as paid job, but I don't have time to finish tests and send it to that persons as 'task done', so I publish it for free to anyone interested to finish this task.

@gesior gesior added the help wanted Extra attention is needed label Feb 12, 2026
Comment thread src/iologindata.cpp
item->serializeTVPFormat(script);
script.writeText(")");
script.writeLine();
for (Condition* condition : player->storedConditionList) {

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable condition is not used.
@carlosmiguelgit

Copy link
Copy Markdown

I have this .tvpp all removed, both player items and house items are saved in database, removed tvpspawn etc etc, but i dont know how to pr this since my git is full custom.

@marcingoralski

marcingoralski commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

Nice effort. We should definitely try to get rid of these "features", especially if they do not affect gameplay at all.
What's missing on this PR @gesior?

@gianpeiter

Copy link
Copy Markdown

Is something missing from this PR?

@gesior

gesior commented Mar 21, 2026

Copy link
Copy Markdown
Collaborator Author

Is something missing from this PR?

Everything should work, but I had no time to test it all:
Not tested yet: depot items [check different towns], storages [string and number], item attributes (of equipped EQ), vip lists, conditions, blessings, capacity and unjust kills.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants