Handle downloads no data available #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eanly If the CDS API does not have any data available we catch this with the error callback. Only the string `Reason: Request returned no data` is available to catch this. If the CDS package would ever change their error messages this would break. As a return code the python errno.ENODATA is used if no data is present. I've not been able to find more widely used default error codes so I would argue that also just using `-10` by convention would be ok instead.
cpaulik
force-pushed
the
handle-downloads-no-data-available
branch
from
184813f
to
b1870ad
Compare
|
Looks good. I think we should optimize the download function here for integration into task schedulers, towards automated data updates. And providing more feedback on a data request is a good start. I don't know how the CDS API will develop, maybe the wrapper here will be obsolete at some point... |
wpreimes
approved these changes
Nov 7, 2021
|
Thanks. Do you have any other things planned for this package in the short term? If not then it would be great if we could tag a new version. |
|
I will add the pipelines to test and release the package and then draft a new version in the next days, is that ok? |
|
Sure, let me know if you need any help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
If the CDS API does not have any data available we catch this with the error
callback. Only the string
Reason: Request returned no datais available tocatch this. If the CDS package would ever change their error messages this would
break.
As a return code the python errno.ENODATA is used if no data is present. I've
not been able to find more widely used default error codes so I would argue that
also just using
-10by convention would be ok instead.Other changes
I've also removed the usage of the
*import in this MR.