Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter configuration key change & Save session with default empty group filters #167

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Filter configuration key change & Save session with default empty group filters #167

merged 3 commits into from
Oct 16, 2023

Conversation

aykutaaykut
Copy link
Collaborator

This is a PR to solve a bug in save-session use case with group filters.

  • By default no group filters are applied for new sessions and the support for adding group filters along with dynamic filters is not yet implemented. This PR is only for hotfix to create sessions with no group filters.
  • FilterDict configuration keys are updated based on the dynamic filter support but full support for dynamic filters is not yet implemented.

@aykutaaykut aykutaaykut added front end Relating to a development task in the frontend. back end Relating to development tasks in the backend. aykut Relating to Aykut's Thesis Topic labels Oct 15, 2023
@aykutaaykut aykutaaykut self-assigned this Oct 15, 2023
@tobifb
Copy link
Collaborator

tobifb commented Oct 16, 2023

Saving a session now works again.

@tobifb tobifb self-requested a review October 16, 2023 22:15
tobifb
tobifb approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@tobifb tobifb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@aykutaaykut aykutaaykut merged commit 6bff8d0 into main Oct 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobifb tobifb tobifb approved these changes

@NCEghtebas NCEghtebas NCEghtebas approved these changes

@VanessaVanessaC VanessaVanessaC Awaiting requested review from VanessaVanessaC

Assignees

@aykutaaykut aykutaaykut

Labels
aykut Relating to Aykut's Thesis Topic back end Relating to development tasks in the backend. front end Relating to a development task in the frontend.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aykutaaykut @tobifb @NCEghtebas