Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend Group Filter Infrastructure #141

Merged
merged 49 commits into from
Oct 15, 2023
Merged

Backend Group Filter Infrastructure #141

merged 49 commits into from
Oct 15, 2023

Conversation

aykutaaykut
Copy link
Collaborator

This pull request implements the infrastructure for group filters and their communication mechanism with the group filter aggregators. It consists of a lot of changes/additions in a lot of files, so I am open to peer review sessions.

aykutaaykut added 29 commits July 31, 2023 14:43
@aykutaaykut
fixed error caused by stdout in pipeline and removed previous fix wit…
fd5e79e 
…h flush
@aykutaaykut
extended Filter base class with group_filter attr.
88d3b40
@aykutaaykut
commented out a debug log
82de62e
@aykutaaykut
added GROUP_FILTER as a message type
70c1496
@aykutaaykut
implemented initial BoW filter template
8e3f2b5
@aykutaaykut
added inital GROUP_FILTER event handler template
f29d621
@aykutaaykut
extended connection api to handle GROUP_FILTER messages
458cc87
@aykutaaykut
added BoW filter button
0e2f3f3
@aykutaaykut
Merge branch 'main' into backend-aa-sync-score
89b8ecb
@aykutaaykut
updated requirements with pyts for bow algorithm
39c0d64
@aykutaaykut
added group filter communication mechanism between participants and e…
60bb1cf 
…xperimenters
@aykutaaykut
wip: implemented bow algorithm with derivatives
9004495
@aykutaaykut
wip: updated preprocessing to be modular
82fad38
@aykutaaykut
wip: implemented oasis algorithm and changed data keys from frame tim…
6ee8df3 
…e to frame number
@aykutaaykut
wip: implemented alignment and oasis algorithm execution
7b9203d
@aykutaaykut
removed filter api endpoint for group filters
fdf7fd0
@aykutaaykut
updated npm packages
2aebb18
@aykutaaykut
removed group filter related attributes and functions
96ef5be
@aykutaaykut
implemented group filter base class
f2b6af3
@aykutaaykut
implemented group filter aggregator
0fde82f
@aykutaaykut
implemented factory and utility functions for group filter and aggreg…
418cd54 
…ator
@aykutaaykut
introduced a new message type for group filters
a3de6f3
@aykutaaykut
removed old group filter implementation
d176353
@aykutaaykut
added group filter related data and updated validation functions
587ad81
@aykutaaykut
implemented set group filter and aggregator functions
601a5c9
@aykutaaykut
implemented group filter extension for connection and track handler
1e07005
@aykutaaykut
updated user factory functions to support group handler passing to th…
ce0ee15 
…eir connections
@aykutaaykut
added SET_GROUP_FILTERS message to remove group filters in None button
eb5d916
@aykutaaykut
Merge branch 'main' into backend-aa-sync-score
459a097
@aykutaaykut aykutaaykut added the enhancement New feature or request label Sep 16, 2023
@aykutaaykut aykutaaykut added back end Relating to development tasks in the backend. aykut Relating to Aykut's Thesis Topic labels Sep 16, 2023
@aykutaaykut aykutaaykut added this to the Realtime Synchrony Score milestone Sep 16, 2023
@aykutaaykut aykutaaykut self-assigned this Sep 16, 2023
@aykutaaykut
solved flake8 errors
8b9fe6c
@aykutaaykut
implemented a template group filter as an example
878bcf9
@aykutaaykut
updated gf aggregator to enabla all participants joining aggregation …
64938bc 
…step
@aykutaaykut
updated __init__ file in group_filters package to automatically impor…
455a5f9 
…t all submodules
@aykutaaykut
manually add gfs in the __init__ file
2d60a37
@aykutaaykut
variable names are updated to make them more self explanatory
dd0e39f
@aykutaaykut
removed unnecessary variables
ec9293b
@aykutaaykut
deleted sync_score filter/folder under filters directory
30dde5e
@aykutaaykut
removed unused attribute
de6e442
@aykutaaykut
removed sync_score from filters's init
567af97
@aykutaaykut
bug fix related to experimenter disconnects after the group filters a…
218b761 
…re disabled + alignment function is changed to a static function in order to reduce the complexity of the code
@aykutaaykut
updated template group filter with a static align_data method and add…
9ec1f61 
…ed comments in order to guide developers with the new group filter creation steps
@aykutaaykut
added more comments
a5bd55d
@aykutaaykut
Merge branch 'main' into backend-aa-sync-score
76f479f
@aykutaaykut
bug fix for experimenter disconnecting after group filters are disabl…
d0e44e0 
…ed is applied to audio group filters
@aykutaaykut
solved some flake8 related formatting issues
31b0cb4
@aykutaaykut
fixed a typo
f1754d8
@aykutaaykut
Copy link
Collaborator Author

hey @NCEghtebas, I implemented the changes, the PR should be ready for merge after your final test. The changes I implemented after our Pair Review session:

  • The bug related to experimenter disconnects after the group filters are disabled is fixed now.
  • Unused attributes in the experimenter are removed.
  • Synchrony score related files under filters directory are removed.
  • Added comments in the template group filter to guide new developers with TODO keyword.
  • Simplified the alignment function implementation inside the group filter by changing it into a static method like aggregate in order to reduce the code complexity and make the code more understandable.

@NCEghtebas
Copy link
Member

Really great work!

@aykutaaykut aykutaaykut merged commit cdf3483 into main Oct 15, 2023
4 checks passed
@NCEghtebas NCEghtebas mentioned this pull request Oct 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NCEghtebas NCEghtebas NCEghtebas approved these changes

Assignees

@aykutaaykut aykutaaykut

Labels
aykut Relating to Aykut's Thesis Topic back end Relating to development tasks in the backend. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aykutaaykut @NCEghtebas