No max angle limitations, moved CAD files to folder #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 21482383841Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
This PR removes the maximum and minimum position degree limitations from the motor control system, allowing unrestricted rotation angles beyond ±360°. The changes eliminate safety constraints that previously clamped motor positions to a single rotation range.
Changes:
- Removed
max_position_degreesandmin_position_degreesfields fromMotorLimitsdataclass - Eliminated position clamping logic and warning messages in
set_position()method - Updated docstring to remove mention of ±360° limitation
Reviewed changes
Copilot reviewed 2 out of 11 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/motor_python/definitions.py | Removed position limit constants from MotorLimits dataclass |
| src/motor_python/cube_mars_motor.py | Removed position validation, clamping logic, and updated documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tsmorz
requested changes
Jan 29, 2026
Tsmorz
requested changes
Jan 29, 2026
- Update position limits to hardware maximum (±2147.5°, ~6 rotations) - Bump version to 0.0.5 - Move PDFs to docs/ directory - Update README structure
Tsmorz
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a brief description of the change and the reasoning behind it.
Reviewers
Required Reviewers
Optional Reviewers
(Feel free to add/remove as needed.)
What Changed?
Describe the main changes in this PR:
Testing
Describe how you verified functionality:
Steps to reproduce/test:
1.
2.
3.
Code Quality Checklist
Before requesting review, ensure:
make formatmake testDocumentation
Additional Notes