Skip to content

Conversation

@CatYang3
Copy link
Collaborator

@CatYang3 CatYang3 commented Dec 16, 2025

Summary

Describe the main changes in this PR:

  • Added a method to calculate gain value for the Madgwick filter
  • Added a plotter to plot IMUDataFile
  • Added calculated gain to IMUConfig
  • Added i2c parameter name to IMUConfig to handle different i2c parameter names in Adafruit's libraries

Code Quality Checklist

Before requesting review, ensure:

  • All CI/CD pipelines pass
  • Code includes docstrings and type hints
  • I added new tests where necessary
  • I ran make tree to update the README.md

Additional Notes

  • Anything else reviewers should know?
  • Attach outputs, plots, logs, or GIFs here.

@CatYang3
Copy link
Collaborator Author

I accidently pushed the large file with recorded data with one of my last commits, that's why there's thousands of lines changed

add i2c parameter name to config
This was linked to issues Dec 16, 2025
Base automatically changed from writer to main December 19, 2025 09:45
@CatYang3 CatYang3 self-assigned this Dec 19, 2025
This data was recorded without setting custom range/data rate and was also recorded without checking if only new data is recorded.
@coveralls
Copy link

coveralls commented Dec 19, 2025

Pull Request Test Coverage Report for Build 20856451012

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+2.5%) to 90.619%

Files with Coverage Reduction New Missed Lines %
imu_python/wrapper.py 2 98.2%
imu_python/base_classes.py 7 91.35%
imu_python/sensor_manager.py 19 74.68%
Totals Coverage Status
Change from base Build 20366190227: 2.5%
Covered Lines: 512
Relevant Lines: 565

💛 - Coveralls

@CatYang3 CatYang3 requested a review from Tsmorz January 8, 2026 15:10
Copy link
Member

@Tsmorz Tsmorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these changes and then it's ready to go! Nice work :)

@CatYang3 CatYang3 merged commit 59dad78 into main Jan 12, 2026
7 checks passed
@CatYang3 CatYang3 deleted the gain branch January 16, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IMU Gain determination IMU gain

4 participants