Retail fixes: class portrait icon + ArcaneBar castbar stability (secure/secret values, safe timing)#11
Open
ronaldfaraj wants to merge 2 commits intoTULOA:mainfrom
Open
Retail fixes: class portrait icon + ArcaneBar castbar stability (secure/secret values, safe timing)#11ronaldfaraj wants to merge 2 commits intoTULOA:mainfrom
ronaldfaraj wants to merge 2 commits intoTULOA:mainfrom
Conversation
Fix lua error in player class portrait
Added defensive handling for Retail “secure/secret” values returned by UNIT_SPELLCAST_* events and timing APIs. Prevented crashes from invalid comparisons/arithmetic (castID, startTime/maxValue/endTime) by validating values before use. Normalized cast timing units (ms vs seconds) and clamped texture coords to avoid out-of-range TexCoord errors. Improved resilience across /reload and target casting events without breaking non-Retail behavior.
Collaborator
Author
|
Hi! Marking this PR as Draft for now. It resolves the Retail Lua errors I encountered, but I later noticed the cast bar behavior is not working correctly after these changes. I need additional testing and adjustments before it’s ready for review/merge. I’ll update the PR once the cast bar is confirmed working end-to-end. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two Retail-focused fixes:
Tested on Retail: no more crashes on /reload, player class portrait works, and target casting no longer triggers ArcaneBar errors.