Metadata reading #67
Metadata reading #67
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionalities to read metadata files from DORIS v4 and v5 corregistration software outputs. The implementation includes a new read_metadata function that can parse metadata from .res files generated by both DORIS versions, handling different file formats and patterns.
- Add
read_metadatafunction to parse DORIS v4/v5 metadata files with configurable drivers - Define regular expression patterns and metadata key configurations for both DORIS versions
- Include comprehensive test coverage for both DORIS v4 and v5 metadata reading scenarios
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sarxarray/_io.py | Implements main metadata reading functionality with driver-specific parsers |
| sarxarray/conf.py | Defines regex patterns and metadata key configurations for DORIS v4/v5 |
| sarxarray/init.py | Exports the new read_metadata function |
| tests/test_io.py | Adds comprehensive test cases for metadata reading functionality |
| docs/data_loading.md | Documents usage examples for both DORIS versions |
| .github/workflows/sonarcloud.yml | Updates CI workflow to include test coverage |
Comments suppressed due to low confidence (1)
docs/data_loading.md:86
- The variable name 'tsx_folder' is inconsistent with the defined 'stack_folder' variable above. It should be 'stack_folder.glob()' for consistency.
res_file_list = list(tsx_folder.glob('???????/slave.res'))
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@fnattino sorry for the delay! Can you help me review this PR? This is regarding reading two types of metadata from Doris. I included the examples in |
There was a problem hiding this comment.
Hey @rogerkuou, very nicely written and documented, very clear! I have left a couple of suggestions. Maybe these things do not make sense in the optics of the people that will actually make use of it, so feel free to discard any comment..
|
Hi @fnattino, I adapted most of your comments. Can you give another look when you have time? Thanks a lot for your review! |
|
Add functionalities to read res file metadata generated by doris v4 or v5.
Example files and file strutures are included as test data files under
tests/data/metadata)