Skip to content

fix(#1240): fix overall balance to stay anchored to today across calendar navigation#1350

Open
rbalogic wants to merge 3 commits into
TTLApp:mainfrom
rbalogic:fix/1240-compute-overall-balance
Open

fix(#1240): fix overall balance to stay anchored to today across calendar navigation#1350
rbalogic wants to merge 3 commits into
TTLApp:mainfrom
rbalogic:fix/1240-compute-overall-balance

Conversation

@rbalogic
Copy link
Copy Markdown

Summary

Fixes #1240.

Overall Balance now stays anchored to the real current day, even when navigating to past or future dates in Month/Day views.

What Changed?

  • Anchored Overall Balance calculations to today in both Month and Day views
  • Preserved existing count-today behavior
  • Updated English tooltip copy to match implemented behavior
  • Added renderer test coverage for past/future navigation in both calendar views
  • Stabilized the calendar window wait-mode renderer test

Why This Change?

Navigating the calendar previously made Overall Balance appear to shift with the viewed date.
This update keeps the metric fixed to today for consistent, predictable behavior.

Testing

npm run test:electron-mocha

npx eslint \
  renderer/classes/BaseCalendar.js \
  renderer/classes/MonthCalendar.js \
  renderer/classes/DayCalendar.js \
  __tests__/__renderer__/calendar.mjs \
  __tests__/__renderer__/classes/MonthCalendar.mjs \
  __tests__/__renderer__/classes/DayCalendar.mjs \
  --config configs/eslint.config.mjs

npx prettier -c locales/en/translation.json --config configs/.prettierrc.json

Notes

  • No screenshots included: behavior change only, plus a tooltip text update.

@rbalogic rbalogic changed the title fix(#1240): fix overall balance to stay anchored to today across cale… fix(#1240): fix overall balance to stay anchored to today across calendar navigation Apr 25, 2026
@rbalogic rbalogic force-pushed the fix/1240-compute-overall-balance branch 2 times, most recently from b774338 to d533cdb Compare May 2, 2026 10:10
@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rbalogic rbalogic force-pushed the fix/1240-compute-overall-balance branch from d533cdb to a937a4e Compare May 3, 2026 10:34
@rbalogic
Copy link
Copy Markdown
Author

rbalogic commented May 3, 2026

@tupaschoal Please review this PR when you can and approve workflow if required, Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overall balance updates when changing months

1 participant