Fix Ansible warnings

.ansible-lint

@@ -0,0 +1,5 @@
+skip_list:
+  - '204'
+  - '303'
+  - '305'
+  - '405'

.travis.yml

@@ -70,7 +70,7 @@ script:
     && (echo 'Idempotence test: pass' && exit 0)
     || (echo 'Idempotence test: fail' && exit 1)
 
-  - if [ "$ANSIBLE_VERSION" = "latest" ]; then ansible-lint tests/test.yml || true; fi
+  - if [ "$ANSIBLE_VERSION" = "latest" ]; then ansible-lint tests/test.yml; fi
 
 notifications:
   email: false

README.md

@@ -6,7 +6,7 @@ Set up the latest or a specific version of [Keepalived](http://www.keepalived.or
 
 #### Requirements
 
-* `git-core` (will be installed)
+* `git` (will be installed)
 * `build-essential` (will be installed)
 * `automake` (will be installed)
 * `libtool` (will be installed)

meta/main.yml

@@ -1,6 +1,7 @@
 # meta file for keepalived
 ---
 galaxy_info:
+  role_name: keepalived
   author: Mischa ter Smitten
   company: Oefenweb.nl B.V.
   description: Set up keepalived in Debian-like systems

tasks/main.yml

@@ -6,19 +6,18 @@
     value: "{{ keepalived_ip_nonlocal_bind }}"
     reload: true
     state: present
-  when: keepalived_ip_nonlocal_bind != false
+  when: keepalived_ip_nonlocal_bind
   tags:
     - configuration
     - keepalived
     - keepalived-ip-nonlocal-bind
 
 - name: install dependencies
   apt:
-    name: "{{ item }}"
+    name: "{{ keepalived_dependencies }}"
     state: "{{ apt_install_state | default('latest') }}"
     update_cache: true
     cache_valid_time: "{{ apt_update_cache_valid_time | default(3600) }}"
-  with_items: "{{ keepalived_dependencies }}"
   tags:
     - configuration
     - keepalived
@@ -27,11 +26,10 @@
 
 - name: install additional
   apt:
-    name: "{{ item }}"
+    name: "{{ keepalived_install }}"
     state: "{{ apt_install_state | default('latest') }}"
     update_cache: true
     cache_valid_time: "{{ apt_update_cache_valid_time | default(3600) }}"
-  with_items: "{{ keepalived_install }}"
   tags:
     - configuration
     - keepalived
@@ -65,18 +63,22 @@
     - keepalived-checkout-repository
 
 - name: regenerate the build files
-  shell: aclocal && autoheader && automake --add-missing && autoreconf
+  shell: >
+    aclocal && autoheader && automake --add-missing && autoreconf
   args:
     chdir: "{{ keepalived_checkout_path }}"
-  when: _git_checkout is changed and keepalived_version is version_compare('v1.2.24', '>=')
+  when:
+    - _git_checkout is changed
+    - keepalived_version is version_compare('v1.2.24', '>=')
   tags:
     - configuration
     - keepalived
     - keepalived-build
     - keepalived-build-regenerate-build-files
 
 - name: build
-  shell: ./configure {{ keepalived_configure_options | join(' ') }} && make -j{{ ansible_processor_cores + 1 }}
+  shell: >
+    ./configure {{ keepalived_configure_options | join(' ') }} && make -j{{ ansible_processor_cores + 1 }}
   args:
     chdir: "{{ keepalived_checkout_path }}"
   when: _git_checkout is changed
@@ -98,7 +100,8 @@
     - keepalived-remove-distro
 
 - name: install
-  shell: make install
+  shell: >
+    make install
   args:
     chdir: "{{ keepalived_checkout_path }}"
   when: _git_checkout is changed
@@ -123,7 +126,8 @@
     - keepalived-script-user
 
 - name: cleanup build
-  shell: git reset --hard && git clean -d -x -f
+  shell: >
+    git reset --hard && git clean -d -x -f
   args:
     chdir: "{{ keepalived_checkout_path }}"
   when: _git_checkout is changed
@@ -153,7 +157,7 @@
     group: root
     mode: 0755
   with_items: "{{ _stat_directories.results }}"
-  when: item.stat.exists == false
+  when: not item.stat.exists
   tags:
     - configuration
     - keepalived

tasks/service-systemd.yml

@@ -13,7 +13,8 @@
     - keepalived-service-systemd-update
 
 - name: service | systemd | reload
-  command: systemctl daemon-reload
+  systemd:
+    daemon_reload: true
   when: _update_systemd_script is changed
   tags:
     - keepalived-service-systemd-reload

vars/main.yml

@@ -1,7 +1,7 @@
 # vars file for keepalived
 ---
 keepalived_dependencies:
-  - git-core
+  - git
   - build-essential
   - automake
   - libtool