Skip to content

Hotfix 0.5.1 remove double description fix parameter location of journal-entry#154

Merged
ARBaart merged 1 commit intoTOMP-WG:masterfrom
ARBaart:hotfix-0.5.1
May 6, 2020
Merged

Hotfix 0.5.1 remove double description fix parameter location of journal-entry#154
ARBaart merged 1 commit intoTOMP-WG:masterfrom
ARBaart:hotfix-0.5.1

Conversation

@ARBaart
Copy link
Contributor

@ARBaart ARBaart commented May 6, 2020

As reported by Bob in Slack, there are two errors in the current master release:

  • lines 19 and 20 are duplicate descriptions which breaks the openAPI format
  • the parameters for journal-entry are incorrectly specified as path parameters (they are not in the path), since this is a GET request I have changed it to the most likely correct option, query parameters.

Please review soon, so people can use the fixed version 0.5

Copy link
Collaborator

@edwinvandenbelt edwinvandenbelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. They are indeed wrong. Please go ahead

@ARBaart ARBaart merged commit 5cbc718 into TOMP-WG:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants