Amendments to Edwin's PR#139
Merged
edwinvandenbelt merged 34 commits intoTOMP-WG:develop-majorfrom Apr 23, 2020
Merged
Conversation
To avoid confusion between TOMP API testing environment and the Data String Learning environment
…n deserializing objects you'll find out this not working.
Presentation of Mark Cartwright during WG TOMP-WG#22
Develop minor - issues TOMP-WG#110, TOMP-WG#112 and TOMP-WG#121
# Conflicts: # TOMP-API.yaml
TOMP-WG#114 remove asset, is included in typeOfAsset TOMP-WG#110 consistency in Operator Information
Changed systemInformation from array to single object Change openingTimes to returnTimes Fix condition inheritance Reference: https://swagger.io/docs/specification/data-models/oneof-anyof-allof-not/ Remove duplicate customer requirements Replace kebab-case with camelCase Add missing TO tags Remove station_status fields from stationInformation Remove duplicate area definition, clarify area usage Remove gender (should be in asset (type) if anywhere) Fix allOf and oneOf syntax Use built-in date format Fix response codes Alphabetise sections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure how if it is possible at all to edit an existing pull request, this is basically PR #123 but with my suggested changes implemented.
Please take a look @edwinvandenbelt