Minor 0.4 - several items

[edwinvandenbelt]

#115 Add GBFS attributes to station information

[pimmeh]

Looks good, although I have a remark on the place of the ETA.

[edwinvandenbelt]

It's for the ETA before a taxi arrives at the pickup location Outlook voor Android downloaden<https://aka.ms/ghei36>

________________________________ From: pimmeh <notifications@github.com> Sent: Wednesday, April 15, 2020 4:53:02 PM To: TOMP-WG/TOMP-API <TOMP-API@noreply.github.com> Cc: Edwin van den Belt <edwinvandenbelt@hotmail.com>; Author <author@noreply.github.com> Subject: Re: [TOMP-WG/TOMP-API] Minor 0.4 - several items (#130) @pimmeh commented on this pull request.

________________________________ In TOMP-API.yaml<#130 (comment)>:

@@ -1749,7 +1815,7 @@ components:

properties: type: type: string - enum: [VEHICLE_NOT_AVAILABLE, USER_NO_SHOW, OTHER] + enum: [VEHICLE_NOT_AVAILABLE, USER_NO_SHOW, ETA, OTHER] I think the ETA is weird here. For one thing, the description states that this notification is for issues. The other thing is that there is already a leg-progress object (line 1733 / 1799) and I see ETA more of an update of that. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#130 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACPLCNQBADXIAUYUVJ2PCG3RMXC45ANCNFSM4L2E2AQQ>.

[edwinvandenbelt]

The current situation is that TOs often request passports, driver licenses, home addresses and birthdays. Somehow this info should be supplied to the TO. Outlook voor Android downloaden<https://aka.ms/ghei36>

________________________________ From: pimmeh <notifications@github.com> Sent: Wednesday, April 15, 2020 4:48:29 PM To: TOMP-WG/TOMP-API <TOMP-API@noreply.github.com> Cc: Edwin van den Belt <edwinvandenbelt@hotmail.com>; Author <author@noreply.github.com> Subject: Re: [TOMP-WG/TOMP-API] Minor 0.4 - several items (#130) @pimmeh commented on this pull request.

________________________________ In TOMP-API.yaml<#130 (comment)>:

@@ -1210,7 +1204,7 @@ components:

type: array items: type: string - enum: [FROM-ADDRESS, TO-ADDRESS, BIRTHDATE, EMAIL, PERSONAL-ADDRESS] + enum: [FROM-ADDRESS, TO-ADDRESS, BIRTHDATE, EMAIL, PERSONAL-ADDRESS, GENDER, PHONE-NUMBERS, LICENSES, BANK-CARDS, DISCOUNT-CARDS, TRAVEL-CARDS, ID-CARDS, CREDIT-CARDS] I'm not exactly sure what this object is for, but I see a lot of personal data being transferred between parties here. Isn't the idea of TOMP to NOT do that? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#130 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACPLCNSUTO753UH7BSG6S2TRMXCL3ANCNFSM4L2E2AQQ>.

[pimmeh]

It's for the ETA before a taxi arrives at the pickup location Outlook voor Android downloadenhttps://aka.ms/ghei36
________________________________ From: pimmeh notifications@github.com Sent: Wednesday, April 15, 2020 4:53:02 PM To: TOMP-WG/TOMP-API TOMP-API@noreply.github.com Cc: Edwin van den Belt edwinvandenbelt@hotmail.com; Author author@noreply.github.com Subject: Re: [TOMP-WG/TOMP-API] Minor 0.4 - several items (#130) @pimmeh commented on this pull request.
________________________________ In TOMP-API.yaml<#130 (comment)>:
@@ -1749,7 +1815,7 @@ components:
properties: type: type: string - enum: [VEHICLE_NOT_AVAILABLE, USER_NO_SHOW, OTHER] + enum: [VEHICLE_NOT_AVAILABLE, USER_NO_SHOW, ETA, OTHER] I think the ETA is weird here. For one thing, the description states that this notification is for issues. The other thing is that there is already a leg-progress object (line 1733 / 1799) and I see ETA more of an update of that. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#130 (review)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACPLCNQBADXIAUYUVJ2PCG3RMXC45ANCNFSM4L2E2AQQ.

But still, then it is not an issue that constitutes a problem, right? It's regarding updates of the leg. Don't we have different endpoints for that? If not, should we?

[JRobertoReyesG]

Looks good! Just made that suggestion for the gender enum. Thanks for the work Edwin :)

Pim agreed, it's to facilitate ETA before the leg started