Issue-829: Write Parallel JUnit 4 tests #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package with the dodgy name is actually a recommendation from the JUnit 4 site itself, therefore I opted to use it here. Contrary to JUnit5 I opted against having a second method in the classes, because paralellization works on class level only anyway which means that the method just lost what little use they had. Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
fudler
reviewed
Mar 28, 2022
| } | ||
|
|
||
| public JUnit4InheritedParallelizationTest(int i){ | ||
| this.i = i; |
There was a problem hiding this comment.
Is this constructor ever needed explicitly?
There was a problem hiding this comment.
Yes, because that's how JUnit4 Injects the values from the data provider
fudler
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package with the dodgy name is actually a recommendation from the JUnit 4 site itself, therefore
I opted to use it here.
Contrary to JUnit5 I opted against having a second method in the classes, because paralellization works on class level only anyway which means that the method just lost what little use they had.
Signed-off-by: l-1squared 30831153+l-1squared@users.noreply.github.com