Update scala dependencies #619
Conversation
There was a problem hiding this comment.
Hi @seblm,
first off, many thanks for your contriubution. I greatly appreciate your effort in improving the scala example project, especially because my expertise regarding scala is rather limited.
Besides the comments i left in this review, I would like to ask you to rename your commit. While formating and moving the files within this commit is fine by me, I think such action should be reflected in the commit message. Maybe a message like "Refurbish scala example project" would be more fitting
| ) | ||
| libraryDependencies ++= Seq( | ||
| "com.tngtech.jgiven" % "jgiven-junit5" % "1.0.0" % Test, | ||
| "net.aichler" % "jupiter-interface" % JupiterKeys.jupiterVersion.value % Test, |
There was a problem hiding this comment.
(note) uses Apache-2.0. Licence. Same as us, so that should be ok.
example-projects/scala/README.md
Outdated
| @@ -4,3 +4,5 @@ Execute the tests and generate the HTML report: | |||
| ``` | |||
| sbt test jgivenReport | |||
| ``` | |||
|
|
|||
| HTML report is written into `target/jgiven-reports/html` | |||
There was a problem hiding this comment.
given that target is a variable, that would not be necessarily true, right? If so, could you just rephrase the sentence to something like "report default location is...."
| given.some_another_state() | ||
| when.some_action() | ||
| `then`.some_outcome | ||
| () |
There was a problem hiding this comment.
You've right : there is no need to explicitly terminates each test with unit value. I'll remove that.
| @@ -1,4 +1,4 @@ | |||
| #Activator-generated Properties | |||
There was a problem hiding this comment.
could you just remove the comment? It is no longer true, now that you edited the file manually
|
@l-1squared at merge: add contribution by saiblerm |
Maybe saiblerm had some typos. Do you mean seblm? |
Update scala dependencies: - junit from 4.12 to 5.7.0 - sbt from 0.13.8 to 1.5.0 - scala from 2.11.7 to 2.13.5 - slf4j-simple from 1.7.13 to 1.7.30 Move tests to a package. Remove useless production code. Format code with scalafmt. Signed-off-by: Sébastian Le Merdy <567637+seblm@users.noreply.github.com>
@l-1squared, I have rename the commit accordingly. |
yes :) |
Also move tests to a package and remove useless production code.
I am not sure about reformatting scala code with scalafmt because you don't want any pull request reformat a file. Please let me know if you want me to revert reformatting.
Thank you for delivering JGiven: it's a great tool!