-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented nested steps #17 (+ text report only) #174
Conversation
Hiya, any comments or suggestions about this? |
Hi, sorry, I already worked a bit on it, but did not came very far yet due to lack of time. You can have a look at the new branch |
I slightly adapted your implementation and also took the chance to refactor the method intercepting code. I also changed a bit the way the nested steps are printed. In particular, I believe the fail status should be printed after the nested step that actually failed. |
Nice one, thank you, Jan! As far as I can see the failed status will appear only on the parent top most state. Current
whereas the following would be desirable?
|
With the current implementation the parent step will not be shown as failed. But I agree that this makes sense. I will change that. |
…steps in the console report (#174)
…steps in the console report (#174)
well done, that looks brilliant! |
Hello, this is an attempt to support nested steps.
I had to change a few things around ScenarioModelBuilder to keep a stack of steps so we can add a nested step to the right parent and supporting multilevel nesting.
As for the report, I have just done it for the plain text report. Note that the nested steps are for report purposes only, i.e. the step status, duration, attachments, etc, are really kept at the top level only. Otherwise it gets too complicated.
If this is accepted, a separate issue should be created for html5 report maybe with a collapsible widget