Feature/more flexible as provider #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-1squared
force-pushed
the
feature/more-flexible-as-provider
branch
2 times, most recently
from
20c6090
to
a8cc2cd
Compare
fudler
reviewed
May 13, 2024
docs/stages.adoc
Outdated
| @@ -66,6 +67,7 @@ public MyStage some_step() { | |||
| return self(); | |||
| } | |||
| ---- | |||
| In additon, the `@As` annotation allows declaring an `AsProvider` that handles the step name generation. A default provider can be set via in a JGiven configuration. | |||
There was a problem hiding this comment.
can be set via [???] in a ...
jgiven-core/src/main/java/com/tngtech/jgiven/config/AbstractJGivenConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
l-1squared
force-pushed
the
feature/more-flexible-as-provider
branch
from
5034d4c
to
3ac595e
Compare
fudler
previously approved these changes
Jun 17, 2024
jgiven-core/src/test/java/com/tngtech/jgiven/impl/ConfigurationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
l-1squared
force-pushed
the
feature/more-flexible-as-provider
branch
from
3ac595e
to
30472a9
Compare
fudler
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing:
[x] documentation
[x] tests
[x] works for method names.
[x] check once for a real JGiven test
[x] double check using As provider for method descriptions -- getDescription uses it. If anything we're more correct now