Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

part of json reports not created when running in testng parallel mode #409

Closed
adrian-herscu opened this issue Jun 5, 2019 · 1 comment
Closed

part of json reports not created when running in testng parallel mode #409

adrian-herscu opened this issue Jun 5, 2019 · 1 comment
Labels
bug TestNG
Milestone
v0.18.1

Comments

@adrian-herscu
Copy link

adrian-herscu commented Jun 5, 2019 •
edited
Loading

Not having enough time to prove this, but it seems that ScenarioTestListener class incorrectly manages its reportModels. This field is defined as a non-final instance and is overridden during onStart. The observed effect is that when running with suite parallel="tests", all defined test classes are executed but not all json files are generated.

https://github.com/TNG/JGiven/blob/master/jgiven-testng/src/main/java/com/tngtech/jgiven/testng/ScenarioTestListener.java#L111
@janschaefer janschaefer added this to the v1.0.0 milestone Jun 5, 2019
janschaefer added a commit that referenced this issue Sep 2, 2019
@janschaefer
Make TestNG ScenarioTestListener work with parallel="tests" option (#409
d797c3e 
)
janschaefer added a commit that referenced this issue Sep 2, 2019
@janschaefer
Make TestNG ScenarioTestListener work with parallel="tests" option (#409
4481185 
)
@janschaefer janschaefer modified the milestones: v1.0.0, v0.18.1 Sep 2, 2019
@janschaefer
Copy link
Contributor

Fixed by not using any field anymore.

janschaefer added a commit that referenced this issue Sep 2, 2019
@janschaefer
changlog #409
23a23fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug TestNG
Projects
None yet
Milestone
v0.18.1
Development

No branches or pull requests
2 participants
@adrian-herscu @janschaefer