Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested steps are not reported with jgiven-spring #259

Closed
s-bortolussi opened this issue Dec 1, 2016 · 3 comments
Closed

Nested steps are not reported with jgiven-spring #259

s-bortolussi opened this issue Dec 1, 2016 · 3 comments
Labels
bug Spring
Milestone
v0.14.0

Comments

@s-bortolussi
Copy link

s-bortolussi commented Dec 1, 2016 •
edited
Loading

Hi

When running a spring scenario test with @NestedSteps , it seems that nested steps are not reported.

Did I miss something in my config ?

Thanks for your help
s-bortolussi added a commit to orange-cloudfoundry/JGiven that referenced this issue Dec 1, 2016
@s-bortolussi
Nested steps not reported with jgiven spring
8b827e4 
[TNG#259]
@janschaefer
Copy link
Contributor

You don't have to configure anything for that to work. Might be a bug. I will try to reproduce that.

@janschaefer
Copy link
Contributor

I could reproduce the issue and it is harder to fix then expected.

janschaefer pushed a commit that referenced this issue Dec 11, 2016
Rewrite of the Spring integration
80183a0 
- Instead of using a Spring-based interceptor, the new integration uses
  the standard JGiven interceptor using ByteBuddy.
- The implementation is based on using a BeanFactoryPostProcessor that
  replaces the original Stage bean class with the one created by
  ByteBuddy

Fixes #259
@janschaefer janschaefer mentioned this issue Dec 11, 2016
Merged
@janschaefer janschaefer added this to the v0.14.0 milestone Dec 11, 2016
janschaefer pushed a commit that referenced this issue Dec 11, 2016
Rewrite of the Spring integration
cff0400 
- Instead of using a Spring-based interceptor, the new integration uses
  the standard JGiven interceptor using ByteBuddy.
- The implementation is based on using a BeanFactoryPostProcessor that
  replaces the original Stage bean class with the one created by
  ByteBuddy

Fixes #259
@s-bortolussi
Copy link
Author

@janschaefer thanks for the update

janschaefer pushed a commit that referenced this issue Dec 12, 2016
Rewrite of the Spring integration
632543b 
- Instead of using a Spring-based interceptor, the new integration uses
  the standard JGiven interceptor using ByteBuddy.
- The implementation is based on using a BeanFactoryPostProcessor that
  replaces the original Stage bean class with the one created by
  ByteBuddy

Fixes #259
janschaefer pushed a commit that referenced this issue Dec 13, 2016
Rewrite of the Spring integration
2adc1af 
- Instead of using a Spring-based interceptor, the new integration uses
  the standard JGiven interceptor using ByteBuddy.
- The implementation is based on using a BeanFactoryPostProcessor that
  replaces the original Stage bean class with the one created by
  ByteBuddy

Fixes #259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Spring
Projects
None yet
Milestone
v0.14.0
Development

No branches or pull requests
2 participants
@janschaefer @s-bortolussi