testng reports failing jgiven test cases as passing

[adrian-herscu]

Given a TestNG-based test with a data provider
And the data provider provides at least two cases
And one case fails
When running the test
Then the TestNG report should contain one failed case

Instead all tests cases are reported as passing.
This behavior is since version 0.8.3.

[janschaefer]

So the TestNG report is wrong, but the JGiven report is correct?

[adrian-herscu]

Yes the JGiven report is correct but the TestNG report is wrong.
This has further implications. When running under Maven the build status is always successful. When this happens under a CI server then not failure notifications are sent.

[janschaefer]

I actually introduced the bug when I fixed #123. Too bad that my test did not test the TestNg status, but only the JGiven status :-(
The bug is fixed now in the 0.9.1-SNAPSHOT version.

[janschaefer]

I back ported this fix to 0.8.x and will release a 0.8.4 version with that fix

[janschaefer]

0.8.4 is released with this fix

[janschaefer]

Due to the severity of the issue I also released v0.9.1 with this fix