failing rules also show how often a rule was violated

[hankem]

Especially when working with legacy code, rules may have a large number of violations.
It is often helpful to have this number explicitly displayed, for example to easily judge whether a refactoring reduces the number or not.

I hereby agree to the terms of the ArchUnit Contributor License Agreement.

[codecholeric]

Thanks for the PR 😃
I'll gladly merge this, do you think, you could add a test for this improved feature though? E.g. in ArchRuleTest

@Test
public void reports_number_of_violations() {
    EvaluationResult result = all(classes()).should(addFixedNumberOfViolations(3)).evaluate(javaClassesViaReflection(Object.class, String.class));

    assertThat(result.getFailureReport().toString()).contains("(6 times)");
}

where

private static ArchCondition<JavaClass> addFixedNumberOfViolations(final int number) {
    return new ArchCondition<JavaClass>(String.format("be violated exactly %d times", number)) {
        @Override
        public void check(JavaClass item, ConditionEvents events) {
            for (int i = 0; i < number; i++) {
                events.add(SimpleConditionEvent.violated(item, item.getSimpleName() + " violation " + i));
            }
        }
    };
}

I'd hate to destroy the number of violations in half a year 😉

[hankem]

Of course – especially given that you pointed out both the appropriate location and the implementaion! ;)