fix(scaffold): add mcp-server type templates and branch workflow generation#70
Merged
Merged
Conversation
…ration Scaffold was generating cursor-plugin workflows unconditionally for all repo types. An mcp-server scaffold produced: an empty validate.yml jobs block, a release.yml that required .cursor-plugin/plugin.json, and a pages.yml that invoked build_site.py. Add six new templates for the mcp-server type path: - validate.mcp.yml.j2: required-files check (README, CHANGELOG, AGENTS, CLAUDE, mcp-tools.json, site.json, LICENSE) - release.mcp.yml.j2: simplified tag-from-package.json release workflow - pages.mcp.yml.j2: static docs/ artifact deploy (no build_site.py) - publish.yml.j2: npm publish on release event - package.json.j2: parametrized Node package manifest - docs/index.mcp.html.j2: placeholder GitHub Pages landing page Branch create-tool.py workflow generation on args.type so mcp-server repos get the four mcp-server workflows and cursor-plugin repos continue to get validate, release, pages unchanged. Also generate package.json and docs/index.html for mcp-server type repos. Verified: freshly scaffolded mcp-server passes YAML validation for all seven workflow files and is mutually consistent with zero hand-fixing. Cursor-plugin output is byte-for-byte unchanged. Signed-off-by: fOuttaMyPaint <154358121+TMHSDigital@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Signed-off-by: fOuttaMyPaint <154358121+TMHSDigital@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp-servertype:validate.mcp.yml.j2,release.mcp.yml.j2,pages.mcp.yml.j2,publish.yml.j2,package.json.j2,docs/index.mcp.html.j2create-tool.pyworkflow generation onargs.typesomcp-serverrepos get four mcp-server-specific workflows pluspublish.yml, whilecursor-pluginrepos continue to get the existing validate/release/pages unchangedpackage.jsonanddocs/index.htmlformcp-servertype repos; cursor-plugin repos are unaffectedRoot cause
create-tool.pywrote all workflow files unconditionally regardless of type. For--type mcp-server:validate.ymlproduced an emptyjobs:block (Jinja2 branch had no else body),release.ymlexpected.cursor-plugin/plugin.json,pages.ymlinvokedbuild_site.py, andpublish.yml/package.json/docs/index.htmlwere never generated.Verification
mcp-server: all 7 workflow files pass YAML validation, cross-file references consistent (release.ymlreadspackage.jsonwhich is now generated;pages.ymldeploysdocs/which now containsindex.html). Zero hand-fixing required.python -m py_compile scaffold/create-tool.pypasses.Test plan
validate-scaffolddry-run passes (cursor-plugin + mcp-server addon path unchanged)safety-scanpasses (no email leak in new templates)sync-checkpasses (no registry change in this PR)version-bump-checkpasses (fix: commit with VERSION unchanged requires no bump per[skip version]-- actually this is a fix: commit so VERSION must be bumped... wait, VERSION is already at 1.15.0 and was bumped in the prior PR for the cfx-mcp registry addition)🤖 Generated with Claude Code