Additions to libnoiseforjava #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 5, 2012 12:14
…ctual copyright information). It was having problems with Intellij on Windows. I know it sucks, sorry guys.
…re easier for me in one place. Also, const; I want to be able to pass new Const(x) to other modules
… time we want to gradient isn't a good idea in Java. According to my runs through VisualVM, this small change speeds up the drawing time x1000. I'd be interested if others that have more complex requirements see a similar difference.
… anyone requests.
|
Yes the VectorTable change (michaelnugent@4063059) makes things significantly faster. After using the library a bit, this seems like a must-have update. It's quite a simple change too. |
|
👍 4063059 makes perlin noise about 2x faster. For small 16x16 tiles I got from ~45ms to ~20ms per tile. |
The local variable edgeFallOff was being set instead of the field(Line 205). The getValue method was also using the control module instead of the second module(Line 122). I submitted this as a pull request to the original repository as well, but yours seems like the most likely one to be updated. Sorry for that last pull request, I closed it. I didn't like it saying 600 changes, there are only 2.
BugFix dealing with edge fall off in Select module Thanks for the bug fixes! :)
Javadoc improvement on some class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've been playing with libnoiseforjava. I'm not sure how close to the original you want it, but I've made some additions and optimizations. If you only want to tiny changes, you may still want to take a look at the commit: "4063059dff562f86dd1e90978ecad99cdd4487b4". I see a huge increase in performance with this one.
Mike