[SNAP 3268] Passing trigger interval as long value instead of entire Trigger object #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2019 14:32
instead of passing the whole Trigger object which would have required a custom deserialization logic.
sumwale
pushed a commit
to sumwale/spark
that referenced
this pull request
Nov 5, 2020
…Trigger object (TIBCOSoftware#194) As part of recent structured streaming UI, we introduced a new field for `Trigger` in `QueryStartedEvent`. This field was added to retrieve the configured trigger interval which can be displayed on UI on one of the charts. Since `org.apache.spark.sql.streaming.Trigger` is a trait, JSON deserialization of the same will require custom deserialization logic. Writing the same will be overkill as ultimately the `Trigger` object has only one implementation as of now which `ProcessingTime` and all `ProcessingTime` contains is trigger interval which of `Long` type. Hence instead of passing the whole object as part of the event, we are now passing only the trigger interval.
sumwale
pushed a commit
that referenced
this pull request
Jul 11, 2021
…Trigger object (#194) As part of recent structured streaming UI, we introduced a new field for `Trigger` in `QueryStartedEvent`. This field was added to retrieve the configured trigger interval which can be displayed on UI on one of the charts. Since `org.apache.spark.sql.streaming.Trigger` is a trait, JSON deserialization of the same will require custom deserialization logic. Writing the same will be overkill as ultimately the `Trigger` object has only one implementation as of now which `ProcessingTime` and all `ProcessingTime` contains is trigger interval which of `Long` type. Hence instead of passing the whole object as part of the event, we are now passing only the trigger interval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As part of recent structured streaming UI, we introduced a new field for
TriggerinQueryStartedEvent. This field was added to retrieve the configuredtrigger interval which can be displayed on UI on one of the charts.
Since
org.apache.spark.sql.streaming.Triggeris a trait, JSON deserializationof the same will require custom deserialization logic. Writing the same will be
overkill as ultimately the
Triggerobject has only one implementation asof now which
ProcessingTimeand allProcessingTimecontains is triggerinterval which of
Longtype. Hence instead of passing the whole object aspart of the event, we are now passing only the trigger interval.
How was this patch tested?