Skip to content

Fixes for SNAP-3253: #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2019
Merged

Fixes for SNAP-3253: #187

merged 2 commits into from
Nov 29, 2019

Conversation

snappy-sachin
Copy link

What changes were proposed in this pull request?

  • Call to add structured streaming UI tab is shifted to SnappySession class.
  • Renamed method updateUI to updateUIWithStructuredStreamingTab and
    also changed access modifier from private to protected.

How was this patch tested?

  • Tested manually and precheckin is run. No relevant failures.

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Please review http://spark.apache.org/contributing.html before opening a pull request.

  - Renamed method updateUI to updateUIWithStructuredStreamingTab and
    also changed access modifier from private to protected.
 - Updated log message if Unable to add Structured Streaming UI Tab.
 - Structured Streaming tab prefix-uri changed from "structurestreaming" to "structuredstreaming".
 - scalastyle fixes
@snappy-sachin
Copy link
Author

Merging.

@snappy-sachin snappy-sachin merged commit c53000d into snappy/branch-2.1 Nov 29, 2019
@snappy-sachin snappy-sachin deleted the SNAP-3253 branch November 29, 2019 19:19
sumwale pushed a commit to sumwale/spark that referenced this pull request Nov 5, 2020
- Call to add structured streaming UI tab is shifted to SnappySession class.
- Renamed method updateUI to updateUIWithStructuredStreamingTab and also changed access modifier from private to protected.
- Structured Streaming tab prefix-uri changed from "structurestreaming" to "structuredstreaming".
sumwale pushed a commit that referenced this pull request Jul 11, 2021
- Call to add structured streaming UI tab is shifted to SnappySession class.
- Renamed method updateUI to updateUIWithStructuredStreamingTab and also changed access modifier from private to protected.
- Structured Streaming tab prefix-uri changed from "structurestreaming" to "structuredstreaming".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants