Skip to content

develp branch 작업내용 머지 : develop -> main#95

Merged
heeeeyong merged 16 commits intomainfrom
develop
Aug 12, 2025
Merged

develp branch 작업내용 머지 : develop -> main#95
heeeeyong merged 16 commits intomainfrom
develop

Conversation

@heeeeyong
Copy link
Collaborator

@heeeeyong heeeeyong commented Aug 12, 2025

이하동일

Summary by CodeRabbit

  • New Features
    • 그룹 생성 기능 연동: 필수 입력 검증, 비공개 비밀번호 검사, 중복 제출 방지, 진행 상태 표시.
    • 내 피드 로딩 시 전체 화면 스피너 표시로 대기 UX 개선.
  • Bug Fixes
    • 회원가입 시 쿠키 기반 인증 토큰 탐색을 강화해 인증 상태 인식 신뢰성 향상.
  • Refactor
    • 날짜 선택 휠 제스처 처리 개선으로 터치/스크롤 상호작용이 더 부드러워짐.
    • 일부 컴포넌트 속성 명 일관성 정비.
  • Style
    • 피드 구분선 두께·폭·색상 조정으로 가독성과 레이아웃 개선.

@vercel
Copy link

vercel bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
thip Ready Preview Comment Aug 12, 2025 0:27am

@coderabbitai
Copy link

coderabbitai bot commented Aug 12, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

여러 모듈에서 alias→aliasName으로 타입/프롭명을 변경하고, 방 생성 타입/API를 추가해 CreateGroup에 연동했습니다. 로딩 스피너 컴포넌트를 신설해 MyFeed에 적용했고, 피드 구분선 스타일을 수정했습니다. DateWheel의 이벤트 처리 방식을 리스너 기반으로 리팩터링했습니다. 기본 ACCESS_TOKEN과 회원가입 토큰 탐색 흐름도 갱신했습니다.

Changes

Cohort / File(s) Summary
Alias 필드/프롭 이름 변경 (alias→aliasName)
src/api/comments/getComments.ts, src/api/feeds/getFeedDetail.ts, src/components/common/Post/PostHeader.tsx, src/components/common/Post/Reply.tsx, src/components/common/Post/SubReply.tsx
API 인터페이스와 Post 계열 컴포넌트에서 alias 필드/프롭명을 aliasName으로 변경. 일부 기본값 제거 및 렌더링 참조 업데이트.
방 생성 타입/API/페이지 통합
src/types/room.ts, src/api/rooms/createRoom.ts, src/pages/group/CreateGroup.tsx
방 관련 타입 정의 추가, 방 생성 API 래퍼 추가, CreateGroup에서 요청 페이로드 구성·검증·전송 및 성공 시 이동 처리.
공통 로딩 스피너 도입 및 적용
src/components/common/LoadingSpinner.tsx, src/components/feed/MyFeed.tsx
공통 LoadingSpinner 컴포넌트 추가. MyFeed 로딩 상태에 전면 스피너 표시로 교체.
피드 구분선 스타일 수정
src/components/feed/FeedPost.tsx, src/components/feed/FeedDetailPost.tsx
구분선 높이/배경/폭 제약(280–500px) 및 중앙 정렬로 스타일 변경.
DateWheel 제스처 처리 리팩터
src/components/creategroup/ActivityPeriodSection/DateWheel.tsx
터치/휠 이벤트를 비패시브 리스너로 등록하고 콜백을 useCallback으로 메모이즈. moveToIndex 중심 흐름으로 통일.
기본 ACCESS_TOKEN 교체
src/api/index.ts
로컬 토큰 부재 시 사용되는 기본 Bearer 토큰 문자열 교체. 인터셉터 로직 변화 없음.
회원가입 토큰 검색/검증 비동기화
src/pages/signup/SignupGenre.tsx
쿠키 기반 토큰 탐색을 다단계 비동기 흐름으로 변경하고, 필요 시 서버 검증(/users/me, credentials: include) 추가. 헤더 설정 흐름 대기 처리.

Sequence Diagram(s)

sequenceDiagram
  participant UI as CreateGroup Page
  participant API as createRoom()
  participant HTTP as apiClient (POST /rooms)
  participant S as Server

  UI->>UI: 사용값 검증(날짜/필수/비공개 비밀번호)
  UI->>API: createRoom(roomData)
  API->>HTTP: POST /rooms (payload)
  HTTP->>S: 요청 전송
  S-->>HTTP: ApiResponse<CreateRoomData>
  HTTP-->>API: response.data
  API-->>UI: { isSuccess, data: { roomId } }
  UI->>UI: 성공 시 상세 페이지로 이동 / 실패 시 알림
Loading
sequenceDiagram
  participant UI as SignupGenre
  participant CK as Cookie Store
  participant CL as apiClient Headers
  participant SV as Server (/users/me)

  UI->>CK: Authorization 쿠키 탐색(여러 단계)
  alt 토큰 발견
    UI->>CL: set Authorization: Bearer <token>
    UI->>UI: 가입 진행
  else 미발견
    UI->>SV: fetch /users/me (credentials: include)
    alt 유효 세션
      UI->>CL: set Authorization: Bearer VALID_AUTH
      UI->>UI: 가입 진행
    else 무효
      UI->>UI: 중단 및 알림/로그
    end
  end
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~40 minutes

Possibly related PRs

Suggested labels

✨ Feature, 🎨 Html&css, 📬 API

Suggested reviewers

  • ljh130334
  • ho0010

Poem

새 방을 여니, 스피너가 빙— 돌아요 ⭕
별칭도 새옷 입고 aliasName이라네요 ✨
휙휙 굴리는 바퀴엔 바람이 실리고
쿠키를 찾아 깡총깡총, 토큰을 물어오죠 🍪
경계선은 얇게, 우리 길은 또렷하게—
오늘도 코드밭에 당근 한 줌 심어요 🥕


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d6df88 and 9cbe956.

⛔ Files ignored due to path filters (1)
  • src/assets/common/loadingspinner.svg is excluded by !**/*.svg
📒 Files selected for processing (15)
  • src/api/comments/getComments.ts (2 hunks)
  • src/api/feeds/getFeedDetail.ts (1 hunks)
  • src/api/index.ts (1 hunks)
  • src/api/rooms/createRoom.ts (1 hunks)
  • src/components/common/LoadingSpinner.tsx (1 hunks)
  • src/components/common/Post/PostHeader.tsx (3 hunks)
  • src/components/common/Post/Reply.tsx (2 hunks)
  • src/components/common/Post/SubReply.tsx (4 hunks)
  • src/components/creategroup/ActivityPeriodSection/DateWheel.tsx (3 hunks)
  • src/components/feed/FeedDetailPost.tsx (1 hunks)
  • src/components/feed/FeedPost.tsx (1 hunks)
  • src/components/feed/MyFeed.tsx (2 hunks)
  • src/pages/group/CreateGroup.tsx (3 hunks)
  • src/pages/signup/SignupGenre.tsx (2 hunks)
  • src/types/room.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@heeeeyong heeeeyong merged commit 61ee49b into main Aug 12, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants