Conversation
feat: 알림센터 알림 유무 확인 기능 구현
- 커스텀 핸들러가 isDragging 플래그를 공유하면서 스크롤 위치를 강제로 덮어써 모바일 스크롤 가속과 충돌하던 부분을 해결했습니다.
- RecruitingGroupCarousel 방식과 동일하게 로직 수정
[FIX] 10월 3주차 QA 사항 - 호준
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
|
Caution Review failedThe pull request is closed. Walkthrough터치 상호작용 지원을 캐러셀 컴포넌트에서 제거했으며, CSS 성능 최적화(translateZ, will-change)를 추가하고, 무한 캐러셀 초기화에 requestAnimationFrame 기반 로직과 리사이즈 디바운싱을 도입했습니다. 그룹 검색의 loadMore 함수는 카테고리 인식 로직과 트림된 검색어를 사용하도록 수정되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Component as Carousel<br/>Component
participant Hook as useInfiniteCarousel
participant RAF as requestAnimationFrame
participant ResizeObs as ResizeObserver
User->>Component: Mount component
activate Hook
Hook->>RAF: Schedule initialize (RAF)
activate RAF
RAF-->>Hook: Trigger initialization
Hook->>Hook: Center middle card
deactivate RAF
ResizeObs->>Hook: Window resize detected
activate Hook
Note over Hook: Debounce 150ms
Hook->>Hook: Cancel pending debounce
Hook->>Hook: Schedule new initialize
Hook->>Hook: Center middle card on resize
deactivate Hook
User->>Component: Unmount component
activate Hook
Hook->>Hook: Clear RAF
Hook->>Hook: Clear debounce timer
deactivate Hook
deactivate Hook
sequenceDiagram
participant User as User
participant Search as GroupSearch<br/>Component
participant API as getSearchRooms<br/>API
participant State as Results State
User->>Search: Trigger loadMore
activate Search
Note over Search: Extract trimmedTerm
Note over Search: Calculate isAllCategory<br/>(empty term + empty category)
alt isAllCategory OR !trimmedTerm
Search->>Search: Skip fetch (guard blocked)
else Valid search criteria
Search->>API: Call with trimmedTerm,<br/>category, isAllCategory
activate API
API-->>State: Return paginated results
deactivate API
State->>Search: Update results
end
deactivate Search
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes 변경 사항은 여러 파일에 걸쳐 있지만 터치 핸들러 제거 같은 반복적인 패턴과 새로운 RAF/디바운싱 로직, 검색 파라미터 수정이 혼합되어 있습니다. 각 영역별로 서로 다른 이유로 변경되어 있어 별도의 검토가 필요합니다. Possibly related PRs
Suggested labels
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
기능 변경
스타일