Skip to content

fix: 책 검색 레이아웃 이미지 깨짐#234

Merged
ho0010 merged 2 commits intodevelopfrom
fix/QA9-1
Sep 3, 2025
Merged

fix: 책 검색 레이아웃 이미지 깨짐#234
ho0010 merged 2 commits intodevelopfrom
fix/QA9-1

Conversation

@ho0010
Copy link
Collaborator

@ho0010 ho0010 commented Sep 3, 2025

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

[FIX] 9월 1주차 QA 사항 - 호준 #225

📝작업 내용

  • 책 검색 레이아웃 이미지 깨짐 수정 + 디자인 요구사항 추가 반영

    image
  • 책 상세 페이지 하단 여백 발생

    • post가 비어있을때와 동일하게 min-height 부여

Summary by CodeRabbit

  • 스타일
    • 도서 검색 결과 카드 UI 개선: 표지 이미지가 플렉스 레이아웃에서 축소되지 않도록 처리하고, 텍스트 레이아웃 안정화를 위해 min-width 적용. 제목은 2줄까지만 말줄임 처리(-webkit-line-clamp)로 가독성 향상, 서브타이틀 라인하이트 정리.
    • 검색 결과 리스트를 감싸는 컨테이너를 추가해 화면 최소 높이(min-height: 50vh) 보장. 로딩/빈 상태에서도 레이아웃이 흔들리지 않고 일관된 화면 구성 제공.

책 제목과 저자와 출판사 부분 디자인 요구사항 변경에 따른 수정
post가 없을 때와 동일하게 min-height를 부여
@vercel
Copy link

vercel bot commented Sep 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Sep 3, 2025 7:33am

@coderabbitai
Copy link

coderabbitai bot commented Sep 3, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

검색 도서 결과 카드(BookSearchResult)의 스타일을 조정하고, 검색 페이지(SearchBook)에 피드 영역 래퍼 스타일 컴포넌트(FeedPostContainer)를 추가해 피드 목록을 해당 컨테이너로 감쌌습니다. 로직, 데이터 페칭, 공개 API 시그니처 변경은 없습니다.

Changes

Cohort / File(s) Summary
Search result presentational tweaks
src/components/search/BookSearchResult.tsx
Flex 레이아웃 보정(Cover에 flex-shrink: 0, BookInfo에 min-width: 0), 제목 2줄 생략 처리(-webkit-line-clamp) 및 라인 높이 조정, 부제 라인 높이 정렬. 로직 변경 없음.
SearchBook layout wrapper
src/pages/searchBook/SearchBook.styled.ts, src/pages/searchBook/SearchBook.tsx
새로운 스타일 컴포넌트 FeedPostContainer(min-height: 50vh) 추가 및 export. SearchBook.tsx에서 피드 렌더링을 해당 컨테이너로 래핑. 기존 페칭/빈 상태/로딩 로직 변경 없음.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

🐞 BugFix, 🎨 Html&css

Suggested reviewers

  • heeeeyong
  • ljh130334

Poem

봄바람 타고 책 표지 뽀짝—📚
줄 두 개로 제목을 살짝—꽁꽁!
피드엔 아늑한 컨테이너 집 한 채,
토끼는 레이아웃에 귓끝을 세우네.
깔끔한 줄맞춤에 깡총! 레이아웃 완성 🐰


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between bba8dc8 and 7c12d98.

📒 Files selected for processing (3)
  • src/components/search/BookSearchResult.tsx (1 hunks)
  • src/pages/searchBook/SearchBook.styled.ts (1 hunks)
  • src/pages/searchBook/SearchBook.tsx (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/QA9-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ho0010 ho0010 merged commit cae0452 into develop Sep 3, 2025
2 of 3 checks passed
@ho0010 ho0010 changed the title fix: QA 9월 1주차 추가 이슈 해결 fix: 책 검색 레이아웃 이미지 깨짐 Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant