Skip to content

develp branch 작업내용 머지 : develop -> main#222

Merged
ljh130334 merged 10 commits intomainfrom
develop
Sep 1, 2025
Merged

develp branch 작업내용 머지 : develop -> main#222
ljh130334 merged 10 commits intomainfrom
develop

Conversation

@ljh130334
Copy link
Member

@ljh130334 ljh130334 commented Sep 1, 2025

이하동일

Summary by CodeRabbit

  • 신기능
    • 저장한 도서 목록에 무한 스크롤 도입(마이페이지 저장 탭 및 책 검색 바텀시트 탭/검색 결과). 하단 도달 시 자동 로드와 로딩 스피너 제공.
    • 터치 디바이스에서 좌우 스와이프에 의한 브라우저 탐색을 차단해 세로 스크롤을 유지하며 오작동 방지.
  • 스타일
    • 마이페이지 사용자명/타이틀 타이포그래피 개선(가독성 향상).
    • 게시물 이미지가 컨테이너를 꽉 채우도록 크롭 처리.
    • 저장한 도서 아이템의 너비·정렬 및 마지막 항목 보더 마감 개선.

@vercel
Copy link

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Sep 1, 2025 6:53am

@coderabbitai
Copy link

coderabbitai bot commented Sep 1, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

  • 터치 디바이스에서 좌우 스와이프 내비게이션 방지 코드를 index.html에 추가.
  • 저장/그룹/마이 페이지의 도서 목록에 커서 기반 페이지네이션과 무한 스크롤 도입.
  • BookSearchBottomSheet 흐름에서 탭별 로드 모어 핸들러/상태 추가 및 연결.
  • PostBody 이미지 스타일과 마이페이지 타이포그래피 조정.

Changes

Cohort / File(s) Summary
Touch navigation guard
index.html
터치 제스처 제어용 head 스크립트/스타일 추가: overscroll 비활성화, touch-action 제한, 가장자리 가로 스와이프 시 기본 내비게이션 방지.
Books API pagination
src/api/books/getSavedBooks.ts, src/api/books/getSavedBooksInMy.ts
커서 기반 페이지네이션 도입: nextCursor/isLast 필드 추가, 선택적 cursor 파라미터 지원, params 객체화.
BookSearch bottom sheet pagination
src/components/common/BookSearchBottomSheet/BookList.tsx, src/components/common/BookSearchBottomSheet/BookSearchBottomSheet.tsx, src/components/common/BookSearchBottomSheet/useBookSearch.ts
탭별(저장/그룹) 무한 스크롤 상태와 로드 모어 핸들러 추가. 검색/탭 모드에 따라 onLoadMore/hasNext/isLoadingMore를 선택적으로 연결. BookList의 트리거 조건 단순화.
SavePage infinite scroll
src/pages/mypage/SavePage.tsx
마이페이지 저장 도서 목록에 커서 기반 무한 스크롤 구현: nextCursor/isLast/로딩 상태 관리, IntersectionObserver로 마지막 아이템 감지, 초기 로드 병렬화.
Styling tweaks
src/components/common/Post/PostBody.tsx, src/pages/mypage/Mypage.tsx
PostBody 이미지에 object-fit: cover 적용. 마이페이지 사용자명/타이틀 타이포그래피 토큰 업데이트.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant UI as BookSearchBottomSheet
  participant Hook as useBookSearch
  participant API as /books APIs

  User->>UI: 스크롤 하단 도달
  UI->>Hook: getLoadMoreHandler() 호출
  alt 검색 모드
    Hook->>API: 검색 결과 loadMore(cursor)
    API-->>Hook: { items, nextCursor, isLast }
    Hook-->>UI: 상태 갱신(검색)
  else 저장 탭
    Hook->>API: getSavedBooks(type='saved', cursor)
    API-->>Hook: { bookList, nextCursor, isLast }
    Hook-->>UI: savedBooks 추가 및 커서 갱신
  else 그룹 탭
    Hook->>API: getSavedBooks(type='joining', cursor)
    API-->>Hook: { bookList, nextCursor, isLast }
    Hook-->>UI: groupBooks 추가 및 커서 갱신
  end
  UI-->>User: 추가 아이템 렌더링
Loading
sequenceDiagram
  autonumber
  actor User
  participant Page as SavePage
  participant API as /books/saved

  User->>Page: 마이페이지 열기
  Page->>API: getSavedBooksInMy(cursor=null)
  API-->>Page: { bookList, nextCursor, isLast }
  Page-->>User: 초기 목록 렌더링

  User->>Page: 마지막 아이템 뷰포트 진입(IntersectionObserver)
  alt has nextCursor and not loading and not isLast
    Page->>API: getSavedBooksInMy(cursor=nextCursor)
    API-->>Page: { bookList(+), nextCursor', isLast' }
    Page-->>User: 목록 뒤에 항목 추가
  else 종료 조건
    Page-->>User: 더 이상 로드 없음
  end
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

Suggested labels

✨ Feature, 📬 API, 🎨 Html&css

Suggested reviewers

  • heeeeyong

Poem

토끼는 살짝 점프해, 커서를 코끝에 얹고
스크롤 끝에서 살그머니 더를 불러오죠
왼쪽-오른쪽 바람은 잠재우고
책은 줄줄, 피드는 술술
캬롯 한 입, 목록 두 페이지 더! 🥕📚


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ae3371a and a2c4500.

📒 Files selected for processing (9)
  • index.html (1 hunks)
  • src/api/books/getSavedBooks.ts (2 hunks)
  • src/api/books/getSavedBooksInMy.ts (2 hunks)
  • src/components/common/BookSearchBottomSheet/BookList.tsx (2 hunks)
  • src/components/common/BookSearchBottomSheet/BookSearchBottomSheet.tsx (3 hunks)
  • src/components/common/BookSearchBottomSheet/useBookSearch.ts (5 hunks)
  • src/components/common/Post/PostBody.tsx (1 hunks)
  • src/pages/mypage/Mypage.tsx (1 hunks)
  • src/pages/mypage/SavePage.tsx (6 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ljh130334 ljh130334 merged commit 7e6c9b8 into main Sep 1, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants