Skip to content

fix: MyProfile 변수 수정#213

Merged
heeeeyong merged 1 commit intodevelopfrom
chore/minor-updates
Aug 28, 2025
Merged

fix: MyProfile 변수 수정#213
heeeeyong merged 1 commit intodevelopfrom
chore/minor-updates

Conversation

@heeeeyong
Copy link
Collaborator

@heeeeyong heeeeyong commented Aug 28, 2025

#️⃣연관된 이슈

없음

📝작업 내용

  • MyProfile의 response data의 변수명을 userId -> creatorId로 변경

💬리뷰 요구사항

없음

Summary by CodeRabbit

  • 버그 수정

    • 프로필 화면에서 팔로워 목록 이동 시 잘못된 ID를 사용하는 문제를 수정하여 올바른 크리에이터의 팔로워 목록으로 이동합니다.
    • 내 피드에서 프로필 정보가 올바른 사용자 식별자에 매핑되도록 개선했습니다.
  • 리팩터링

    • 사용자 식별자 명칭을 일관되게 정리하여 컴포넌트 간 전달되는 ID를 ‘creatorId’ 기준으로 표준화했습니다.
    • 프로필 및 팔로워 관련 컴포넌트 간 속성 전달 구조를 단순화해 유지보수성을 향상했습니다.

@vercel
Copy link

vercel bot commented Aug 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 28, 2025 6:56am

@heeeeyong heeeeyong merged commit 623c7bd into develop Aug 28, 2025
2 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Aug 28, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

프로필 식별자 필드를 userId에서 creatorId로 전환했습니다. 타입 정의에 creatorId를 추가하고, Profile과 MyFollower 컴포넌트의 프로퍼티 및 내부 사용을 업데이트했습니다. MyFeed는 Profile에 전달하는 식별자를 profileData.creatorId로 변경했습니다.

Changes

Cohort / File(s) Summary
Feed 컴포넌트 식별자 전환
src/components/feed/MyFeed.tsx, src/components/feed/Profile.tsx, src/components/feed/MyFollower.tsx
MyFeed: Profile에 전달하는 식별자를 profileData.userIdprofileData.creatorId로 변경. Profile: ProfilePropscreatorId?: number 추가 및 MyFollowercreatorId 전달. MyFollower: 퍼블릭 프로퍼티를 userIdcreatorId로 개명하고 클릭 핸들러에서 네비게이션 파라미터를 creatorId 사용.
타입 정의 업데이트
src/types/profile.ts
MyProfileData에 필수 필드 creatorId: number 추가(이를 상속하는 OtherProfileData에도 전파).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant MyFeed
  participant Profile
  participant MyFollower
  participant Router as Router/Navigate

  MyFeed->>Profile: render({ creatorId: profileData.creatorId, ... })
  note right of Profile: ProfileProps에 creatorId 추가

  Profile->>MyFollower: render({ creatorId, ... })
  note right of MyFollower: userId → creatorId 전환

  User->>MyFollower: "더보기" 클릭
  MyFollower->>Router: navigate(`/follow/followerlist/${creatorId}`)
  Router-->>User: FollowerList 화면
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

🐞 BugFix

Poem

귀 쫑긋 토끼가 깡총깡총 뛰네, creatorId를 찾아가네!
userId는 인사하고 살짝 물러서고,
프로필과 팔로워는 길을 다시 잇네.
클릭 한 번에 길이 환히 열려,
"/follow/followerlist/{creatorId}"로 풍덩—야호! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e55cef6 and d34dcdf.

📒 Files selected for processing (4)
  • src/components/feed/MyFeed.tsx (1 hunks)
  • src/components/feed/MyFollower.tsx (1 hunks)
  • src/components/feed/Profile.tsx (3 hunks)
  • src/types/profile.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/minor-updates

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@heeeeyong heeeeyong self-assigned this Aug 28, 2025
@heeeeyong heeeeyong added the 🐞 BugFix Something isn't working label Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 BugFix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant