Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. WalkthroughAPI 모듈들의 오류 처리에서 AxiosError 타입 가드를 도입해 코드를 엄격화했고, 페이지 컴포넌트들은 unknown 오류에 대한 런타임 가드를 추가해 메시지 기반 리다이렉트를 안전하게 유지했습니다. 스타일 파일에는 focus-visible 아웃라인 규칙이 추가되었습니다. 공개된 시그니처 변경은 없습니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Page as Page (GroupDetail/Participated/Members)
participant API as API (getRoomDetail/Members/Playing)
participant Server as Backend
Note over Page,API: 호출 시 오류는 unknown으로 포착<br/>메시지 접근 전 instanceof Error 가드
User->>Page: 화면 진입/데이터 요청
Page->>API: fetch room data
API->>Server: HTTP 요청
Server-->>API: 응답 또는 오류
alt AxiosError && code == 100004
API-->>Page: throw Error("모집기간이 만료된 방입니다.")
Page->>Page: err instanceof Error 확인
Page-->>User: /group/detail/joined/{roomId}로 리다이렉트
else AxiosError && code == 140011
API-->>Page: throw Error("방 접근 권한이 없습니다.")
Page->>Page: err instanceof Error 확인
Page-->>User: /group 또는 유지된 경로로 리다이렉트
else Non-Axios or 기타 코드
API-->>Page: 원본 오류 재throw
Page->>Page: err instanceof Error 가드 후 일반 처리/로그
Page-->>User: 일반 오류 메시지 표시
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (7)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
타입 에러 수정 후 다시 PR 올립니다.
Summary by CodeRabbit