Skip to content

develp branch 작업내용 머지 : develop -> main#189

Merged
ljh130334 merged 12 commits intomainfrom
develop
Aug 20, 2025
Merged

develp branch 작업내용 머지 : develop -> main#189
ljh130334 merged 12 commits intomainfrom
develop

Conversation

@ljh130334
Copy link
Member

@ljh130334 ljh130334 commented Aug 20, 2025

이하동일

Summary by CodeRabbit

  • 신규 기능
    • 메모 기록에 프로필 이미지 표시
    • 투표 항목에 투표 전 상태(퍼센트/최고 표시 숨김) 지원
  • UX 개선
    • 기록 아이템: 롱프레스 대신 탭으로 더보기 메뉴 열기
    • 그룹 생성: 날짜 유효성 실시간 반영으로 완료 진행 제어
    • 삭제/나가기 동작 안내를 스낵바로 표시
    • 도서 검색 빈 상태 문구 개선
  • 스타일
    • 그룹 도서 섹션 제목/저자 말줄임 처리 및 레이아웃 조정
    • 그룹 카드 커버 이미지 상단 기준 크롭
    • 페이지 입력 폭 계산 및 줄바꿈 방지 개선
    • 텍스트 영역 패딩 조정
    • 참여 그룹 상세 정렬 변경(상단 정렬)

@vercel
Copy link

vercel bot commented Aug 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 20, 2025 3:18pm

@coderabbitai
Copy link

coderabbitai bot commented Aug 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

여러 UI/스타일 수정과 상호작용 흐름 조정이 포함됨. 생성 그룹의 날짜 유효성은 자식→부모 콜백으로 보고되며, 메모리 레코드는 클릭 기반 메뉴로 전환되고 프로필 이미지 URL이 타입/데이터 흐름에 추가됨. 일부 페이지는 알림을 Snackbar로 대체. 기타 텍스트/레이아웃 스타일 조정.

Changes

Cohort / File(s) Summary of Changes
메모리 레코드 타입·렌더링 업데이트
src/types/memory.ts, src/pages/memory/Memory.tsx, src/components/memory/RecordItem/RecordItem.styled.ts, src/components/memory/RecordItem/RecordItem.tsx, src/components/memory/RecordItem/PollRecord.tsx
Record 타입에 profileImageUrl 필드 추가 및 변환 로직 반영. UserAvatar가 src를 받아 배경이미지로 표시. RecordItem은 롱프레스 제거 후 클릭으로 더보기 메뉴 오픈, 아바타 URL 사용. PollRecord는 투표 없음 상태(hasVotes) 처리 추가(막대/퍼센트/최고값 하이라이트 비활성).
그룹 생성: 날짜 유효성 콜백 도입
src/components/creategroup/ActivityPeriodSection/ActivityPeriodSection.tsx, src/pages/group/CreateGroup.tsx
ActivityPeriodSection에 onValidationChange 콜백 prop 추가 및 isDateValid 전달. 부모(CreateGroup)는 isDateValid 상태로 폼 유효성 판단. 기존 제출 직전 인라인 검증 로직 제거.
Snackbar 도입(알림 대체)
src/components/today-words/MessageList/MessageList.tsx, src/pages/groupDetail/ParticipatedGroupDetail.tsx
삭제/나가기 등 개발중 기능 알림을 alert/네비게이션 대신 openSnackbar로 표시(variant: top, isError: true). 기존 confirm 흐름은 유지하되 확인 시 Snackbar 호출로 변경.
스타일·레이아웃 조정
src/components/group/GroupBookSection.styled.ts, src/components/group/GroupCard.tsx, src/components/createpost/PostContentSection.styled.ts, src/components/recordwrite/PageRangeSection.styled.ts, src/pages/groupDetail/ParticipatedGroupDetail.styled.ts
텍스트 줄임표/크기 제어(BookTitle/Author, RightSection gap·shrink), 카드 커버 object-position: top, TextArea padding: 0 및 표현식 괄호화, 페이지 입력 폭 계산/축소 방지, ParticipatedWrapper 정렬(center→flex-start).
복수 언어 문자열 수정
src/components/common/BookSearchBottomSheet/BookSearchStates.tsx
빈 상태 문구를 “현재 등록된 책이 아닙니다.”에서 “현재 등록된 책이 없습니다.”로 변경.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User as 사용자
  participant CG as CreateGroup(부모)
  participant APS as ActivityPeriodSection(자식)

  User->>APS: 시작/종료 날짜 입력 변경
  APS->>APS: isDateValid = !isOverMaxDays && !isEndDateBeforeStart
  APS-->>CG: onValidationChange(isDateValid)
  CG->>CG: isFormValid 계산에 isDateValid 반영
  User->>CG: 완료 클릭
  alt isFormValid
    CG->>API: createRoom(...)
    API-->>CG: 응답
  else invalid
    CG->>User: 진행 불가(버튼 비활성 등)
  end
Loading
sequenceDiagram
  autonumber
  actor U as 사용자
  participant RI as RecordItem
  participant Menu as MoreMenu

  U->>RI: 클릭
  alt 내 게시글
    RI->>Menu: openMoreMenu({ type: writer })
  else 타인 게시글
    RI->>Menu: openMoreMenu({ type: report })
  end
Loading
sequenceDiagram
  autonumber
  actor U as 사용자
  participant ML as MessageList / GroupDetail
  participant Popup as usePopupActions
  U->>ML: 삭제/나가기 확인
  ML->>Popup: openSnackbar({message: "...개발 중", variant: top, isError: true})
  Popup-->>U: 스낵바 표시
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

✨ Feature, 🎨 Html&css

Suggested reviewers

  • heeeeyong

Poem

( )/
(•
•) 오늘도 깡총, 새 기록을 보러 가요!
클릭 한 번에 메뉴가 쏙—롱프레스는 안녕이에요.
아바타 반짝, 프로필 길을 찾았고,
날짜는 자식이 속삭여 부모에게 알려줘요.
삑—스낵바 울려요: “개발 중!” 그래도 전 달려가요.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between bf59ca0 and 7734c10.

📒 Files selected for processing (15)
  • src/components/common/BookSearchBottomSheet/BookSearchStates.tsx (1 hunks)
  • src/components/creategroup/ActivityPeriodSection/ActivityPeriodSection.tsx (2 hunks)
  • src/components/createpost/PostContentSection.styled.ts (2 hunks)
  • src/components/group/GroupBookSection.styled.ts (2 hunks)
  • src/components/group/GroupCard.tsx (1 hunks)
  • src/components/memory/RecordItem/PollRecord.tsx (2 hunks)
  • src/components/memory/RecordItem/RecordItem.styled.ts (1 hunks)
  • src/components/memory/RecordItem/RecordItem.tsx (3 hunks)
  • src/components/recordwrite/PageRangeSection.styled.ts (3 hunks)
  • src/components/today-words/MessageList/MessageList.tsx (3 hunks)
  • src/pages/group/CreateGroup.tsx (3 hunks)
  • src/pages/groupDetail/ParticipatedGroupDetail.styled.ts (1 hunks)
  • src/pages/groupDetail/ParticipatedGroupDetail.tsx (3 hunks)
  • src/pages/memory/Memory.tsx (1 hunks)
  • src/types/memory.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ljh130334 ljh130334 merged commit eef4339 into main Aug 20, 2025
1 of 2 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Aug 21, 2025
This was referenced Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant