Skip to content

develp branch 작업내용 머지 : develop -> main#185

Merged
heeeeyong merged 3 commits intomainfrom
develop
Aug 20, 2025
Merged

develp branch 작업내용 머지 : develop -> main#185
heeeeyong merged 3 commits intomainfrom
develop

Conversation

@heeeeyong
Copy link
Collaborator

@heeeeyong heeeeyong commented Aug 20, 2025

이하동일

Summary by CodeRabbit

  • New Features
    • 피드 로딩 중 로딩 스피너를 표시하여 진행 상태를 명확히 제공합니다.
    • 게시물이 없을 때 빈 상태 화면을 보여 사용자의 혼선을 줄입니다.
    • 프로필에서 상황에 따라 팔로우 버튼 표시를 지원합니다.
  • Refactor
    • 정적 데이터 기반 렌더링을 API 연동 동적 피드 로딩으로 전환해 최신 콘텐츠를 자동 반영합니다.
    • 총 게시물 수 표시 로직을 개선해 보다 정확한 카운트를 제공합니다.

@vercel
Copy link

vercel bot commented Aug 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 20, 2025 1:31pm

@heeeeyong heeeeyong merged commit 2d2084c into main Aug 20, 2025
1 of 2 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Aug 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

OtherFeed 컴포넌트가 정적 posts 렌더링에서 API 기반의 동적 피드 로딩으로 전환되었고, 로딩/에러 상태와 총 개수 상태가 추가되었습니다. isMyself 여부에 따라 내 피드+프로필 병렬 조회 또는 타인 피드 조회를 수행합니다. props에 showFollowButton(optional)이 추가되었습니다.

Changes

Cohort / File(s) Summary
OtherFeed 동적 로딩 및 공개 API 변경
src/components/feed/OtherFeed.tsx
- feedPosts/totalFeedCount/로딩 상태 추가 및 에러 처리 도입
- useEffect로 isMyself 분기: (내 피드+프로필 병렬) 또는 (타인 피드 단일 호출)
- LoadingSpinner/EmptyState 조건 렌더링 도입, TotalBar가 totalFeedCount 사용
- posts prop 의존 제거, API 결과 기반 렌더링
- showFollowButton?: boolean prop 추가 및 Profile에 전달
- getOtherFeed/getMyFeeds/getMyProfile/PostData 등 신규 import 및 타입 확장

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant OtherFeed as OtherFeed Component
  participant API as Feed API
  participant Profile as Profile
  participant UI as UI Elements

  User->>OtherFeed: Mount/props change (userId, isMyself)
  activate OtherFeed
  OtherFeed->>UI: set loading=true
  alt isMyself == true
    par
      OtherFeed->>API: getMyFeeds()
      API-->>OtherFeed: myFeeds[]
    and
      OtherFeed->>API: getMyProfile()
      API-->>OtherFeed: { totalFeedCount, ... }
    end
    OtherFeed->>OtherFeed: set feedPosts, totalFeedCount
  else isMyself == false
    OtherFeed->>API: getOtherFeed(userId)
    API-->>OtherFeed: otherFeeds[]
    OtherFeed->>OtherFeed: set feedPosts
  end
  OtherFeed->>UI: set loading=false
  opt Render
    alt loading
      UI->>UI: LoadingSpinner
    else feedPosts not empty
      OtherFeed->>Profile: render (showFollowButton?)
      OtherFeed->>UI: render posts + TotalBar(totalFeedCount)
    else
      UI->>UI: EmptyState
    end
  end
  deactivate OtherFeed
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

✨ Feature, 📬 API

Poem

귀 쫑긋, 피드 바람 솔솔 분다 🌬️
정적 꿈 접고, API 길을 건다
내 피드? 병렬로 달려 총합 셈!
남 피드? 한 번에 슝—가져옴!
로딩 빙글, 빈 틀엔 별빛 채우고 ✨
팔로우 버튼도 깜박, 토끼는 코를 꿈틀!
(_/)\n> ( •_•)📰\n> /⧹⧹ 총합 OK, 피드 출동!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9969b32 and 53176c8.

📒 Files selected for processing (1)
  • src/components/feed/OtherFeed.tsx (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant