Skip to content

fix: 1μ°¨ QA#179

Merged
ljh130334 merged 34 commits intodevelopfrom
qa/jihyeon
Aug 20, 2025
Merged

fix: 1μ°¨ QA#179
ljh130334 merged 34 commits intodevelopfrom
qa/jihyeon

Conversation

@ljh130334
Copy link
Member

@ljh130334 ljh130334 commented Aug 20, 2025

#️⃣ μ—°κ΄€λœ 이슈

μƒλž΅

πŸ“ μž‘μ—… λ‚΄μš©

1μ°¨ QA μ§„ν–‰ν–ˆμŠ΅λ‹ˆλ‹€.

Summary by CodeRabbit

  • New Features

    • 기둝 μž‘μ„±: 진행도 μ œν•œ μ‹œ λΉ¨κ°„/초둝 툴팁 μ•ˆλ‚΄ μΆ”κ°€, 인풋 κ°€λ³€ λ„ˆλΉ„ 지원 및 μœ νš¨μ„± κ°•ν™”
    • μŠ€λ‚΅λ°” 였λ₯˜ μƒνƒœ(isError) μ§€μ›μœΌλ‘œ μ—λŸ¬ λ©”μ‹œμ§€ 가독성 ν–₯상
    • κΈ°μ–΅ν•˜κΈ°: 잠금(isLocked) λ ˆμ½”λ“œ λΈ”λŸ¬ 처리 및 λΉ„ν™œμ„±ν™”
    • μž₯λ₯΄ νƒœκ·Έ 색상 μžλ™ λ§€ν•‘
    • 였늘의 ν•œλ§ˆλ””: 졜초 λ‘œλ“œ/μž‘μ„± ν›„ μžλ™ 슀크둀, 일일 μ œν•œ ν† μŠ€νŠΈ κ°œμ„ 
  • UI/UX

    • 더보기 메뉴λ₯Ό λ°”ν…€μ‹œνŠΈ λ ˆμ΄μ•„μ›ƒμœΌλ‘œ λ³€κ²½ 및 κ²Œμ‹œκΈ€μ˜ β€œν•€ 고정” λ²„νŠΌ 제거
    • μ—¬λŸ¬ μ„Ήμ…˜ κ°€λ‘œ λ„ˆλΉ„ 계산 κ°œμ„ , λ‚ μ§œ 선택 μ •λ ¬/간격 μ‘°μ •, 읽기 μ „μš© μž…λ ₯ μ‹œ μ‹œκ°μ  ν‘œμ‹œ
    • κ·Έλ£Ή/기둝 진행도 ν‘œκΈ° μ†Œμˆ˜μ  제거, λ„μ„œ μ €μžλͺ…에 β€œμ €β€ ν‘œμ‹œ
    • ν”Œλ ˆμ΄μŠ€ν™€λ” 문ꡬ 닀듬기, 숫자 μž…λ ₯ λͺ¨λ“œλ‘œ μ „ν™˜ 및 λΉ„ν™œμ„±ν™” μ‹œ 클릭 λ°©μ§€
    • λ„μ„œ 상세/λ’€λ‘œκ°€κΈ° 경둜 μ—…λ°μ΄νŠΈ

@vercel
Copy link

vercel bot commented Aug 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 20, 2025 0:09am

@coderabbitai
Copy link

coderabbitai bot commented Aug 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

λ‹€μ–‘ν•œ UI/UX 및 νƒ€μž… μ—…λ°μ΄νŠΈλ₯Ό ν¬ν•¨ν•©λ‹ˆλ‹€. λͺ¨λ‹¬(더보기, μŠ€λ‚΅λ°”) ꡬ쑰와 속성 λ³€κ²½, μ—¬λŸ¬ μŠ€νƒ€μΌ μ‘°μ •, λ©”λͺ¨λ¦¬(기둝) νλ¦„μ˜ 잠금/λΈ”λŸ¬ 및 νŽ˜μ΄μ§€ 수 기반 진행도 계산 λ„μž…, λ ˆμ½”λ“œ ν•„ν„°/μž…λ ₯ UX κ°•ν™”(μ˜€λ²„λ ˆμ΄Β·νˆ΄νŒΒ·λ™μ  μž…λ ₯ 폭), κ·Έλ£Ή/포슀트/였늘의 ν•œλ§ˆλ”” ν…μŠ€νŠΈΒ·λ„€λΉ„κ²Œμ΄μ…˜ μˆ˜μ •μ΄ ν¬ν•¨λ©λ‹ˆλ‹€.

Changes

Cohort / File(s) Summary
BottomSheet/Modal layout
src/components/common/CommentBottomSheet/GlobalCommentBottomSheet.styled.ts, src/components/common/Modal/MoreMenu.tsx
BottomSheet max/min width κ°’ μ‘°μ •. MoreMenu: onPin 제거, 전체 뷰포트 μ˜€λ²„λ ˆμ΄λ‘œ λ ˆμ΄μ•„μ›ƒ λ³€κ²½(λ°”ν…€μ‹œνŠΈ μ •λ ¬), μ»¨ν…Œμ΄λ„ˆ ν¬μ§€μ…˜ λ‹¨μˆœν™”, λ²„νŠΌ νŒ¨λ”© μ‘°μ •.
Snackbar & Popup store
src/components/common/Modal/Snackbar.tsx, src/stores/usePopupStore.ts
Snackbar에 isError prop μΆ”κ°€ 및 색상 반영. Popup store의 SnackbarProps에 isError?: boolean μΆ”κ°€.
Create Group - ActivityPeriod & Room info
src/components/creategroup/ActivityPeriodSection/*.styled.ts, src/components/creategroup/ActivityPeriodSection/ActivityPeriodSection.tsx, src/components/creategroup/RoomInfoSection*.ts*, src/pages/group/CreateGroup.tsx
DateGroup μ •λ ¬ prop(alignItems) μΆ”κ°€, λ‹¨μœ„ ν…μŠ€νŠΈ isLast 지원. RoomInfo κΈ€κΌ΄/ν”Œλ ˆμ΄μŠ€ν™€λ” 색 λ³€κ²½, ν”Œλ ˆμ΄μŠ€ν™€λ” 문ꡬ μˆ˜μ •. 헀더 우츑 λ²„νŠΌ ν…μŠ€νŠΈ κ³ μ •(β€˜μ™„λ£Œβ€™).
Create/Update Post
src/components/createpost/PostContentSection*.ts*, src/pages/post/CreatePost.tsx, src/pages/post/UpdatePost.tsx
TextArea readOnly 기반 μŠ€νƒ€μΌ λ‚΄λΆ€λ‘œ 이동(λ°°κ²½/μ»€μ„œ). 생성/μˆ˜μ • νŽ˜μ΄μ§€ 헀더 우츑 λ²„νŠΌ β€˜μ™„λ£Œβ€™λ‘œ κ³ μ •. 생성 νŽ˜μ΄μ§€μ—μ„œ readOnly=false둜 νŽΈμ§‘ κ°€λŠ₯.
Group sections (width/text tweaks)
src/components/group/CommentSection.styled.ts, .../GroupBookSection*.ts*, .../HotTopicSection.styled.ts, .../RecordSection*.ts*
μ—¬λŸ¬ μ„Ήμ…˜ widthλ₯Ό 90% β†’ calc(100% - 40px)둜 λ³€κ²½. μ €μž ν…μŠ€νŠΈμ— β€˜ 저’ μ ‘λ―Έ μΆ”κ°€. 진행도 νΌμ„ΌνŠΈ ν‘œμ‹œ Math.floor둜 μ •μˆ˜ν™”(ν…μŠ€νŠΈλ§Œ).
Memory Content pruning & spacing
src/components/memory/MemoryContent/MemoryContent*.ts*, .../RecordList*.ts*
DevButton 및 ν† κΈ€ κ΄€λ ¨ prop/둜직 제거. RecordList gap 32β†’40px. 읽기진행도 전달 제거, λ ˆμ½”λ“œλ³„ isLocked둜 λΈ”λŸ¬ μ œμ–΄.
Memory Record item interactions
src/components/memory/RecordItem/PollRecord.tsx, src/components/memory/RecordItem/RecordItem.tsx
PollRecord에 shouldBlur λ„μž…(읽기 μ „μš©/λΉ„ν™œμ„±). RecordItem: νŒμ—… μ•‘μ…˜μ— closePopup 톡합, λ‘±ν”„λ ˆμŠ€ 메뉴 μ†Œμœ μž κΈ°μ€€ λΆ„κΈ°, ν•€ 성곡/μ‹€νŒ¨ μ‹œ νŒμ—… λ‹«κΈ°/μŠ€λ‚΅λ°”, λΈ”λŸ¬μ‹œ μ•‘μ…˜ λΉ„ν™œμ„±.
Memory Filters & Inputs
src/components/memory/RecordFilters/*.ts*, src/components/memory/PageRangeModal*.ts*
overall λ²„νŠΌ λΉ„ν™œμ„± μ‹œ onClick 제거. μž…λ ₯: 숫자 μ „μš© 처리/검증, 전체화면 μ˜€λ²„λ ˆμ΄λ‘œ μ·¨μ†Œ 지원, PageInput 동적 width(inputLength), numberβ†’inputMode=numeric.
Recordwrite PageRange & Tooltip
src/components/recordwrite/PageRangeSection*.ts*
PageInput 동적 width/캐럿 색/μŠ€ν”Όλ„ˆ 제거. InfoIcon 포인터. Tooltip 계열 μ»΄ν¬λ„ŒνŠΈ λ‹€μˆ˜ μΆ”κ°€(variant 지원). ν† κΈ€ μ‹œ 진행도<80이면 λΉ¨κ°„ 툴팁 λ…ΈμΆœ, Info 클릭 μ‹œ 초둝 툴팁. μž…λ ₯ 숫자 검증 κ°•ν™”.
Memory page & types
src/pages/memory/Memory.tsx, src/types/memory.ts
API μ‘λ‹΅μ—μ„œ totalPages/currentUserPage μˆ˜μ§‘, 읽기진행도 계산, Record에 isLocked μΆ”κ°€. hasRecords 흐름 제거. λ’€λ‘œκ°€κΈ° 경둜 μ‘°μ •.
Group detail
src/pages/groupDetail/GroupDetail.styled.ts, src/pages/groupDetail/ParticipatedGroupDetail*.ts*
TagGenreκ°€ genre prop 수용 및 색상 λ§€ν•‘. μ°Έμ—¬ μƒμ„Έμ—μ„œ λ„μ„œ 클릭 경둜 /search/book/{isbn}둜 λ³€κ²½, TagGenre에 genre 전달.
Today Words
src/pages/today-words/TodayWords.tsx
였늘 λ‚ μ§œ 포맷 μœ ν‹Έ μΆ”κ°€. 였늘 λ©”μ‹œμ§€ 카운트 계산 κ°œμ„ (μ—¬λŸ¬ 포맷 비ꡐ, writer만). 초기 λ‘œλ“œ ν›„ μžλ™ 슀크둀. ν† μŠ€νŠΈ isError μ‚¬μš© 및 성곡 ν† μŠ€νŠΈ 쑰건 정ꡐ화. κ²Œμ‹œ ν›„ μž¬λ‘œλ“œμ™€ μžλ™ 슀크둀.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as User
  participant M as Memory.tsx
  participant API as Posts API
  participant RC as RecordList
  participant RI as RecordItem
  participant PR as PollRecord

  U->>M: νŽ˜μ΄μ§€ μ§„μž…
  M->>API: κ²Œμ‹œλ¬Ό λͺ©λ‘ 쑰회
  API-->>M: posts, totalPages?, currentUserPage?
  M->>M: readingProgress 계산, Record.isLocked λ§€ν•‘
  M-->>RC: records 전달
  RC-->>RI: 각 record 전달 (isLocked 포함)
  RI-->>PR: shouldBlur = record.isLocked
  U-->>RI: μ’‹μ•„μš”/λŒ“κΈ€/ν•€ μ‹œλ„
  RI->>RI: shouldBlur? μ•‘μ…˜ λΉ„ν™œμ„±ν™”
Loading
sequenceDiagram
  autonumber
  participant U as User (long-press)
  participant RI as RecordItem
  participant PU as usePopupActions
  participant MM as MoreMenu
  participant SB as Snackbar

  U->>RI: λ‘±ν”„λ ˆμŠ€
  RI->>PU: openMoreMenu(isMyRecord에 따라 μ˜΅μ…˜ λΆ„κΈ°)
  PU-->>MM: 메뉴 ν‘œμ‹œ
  U->>MM: Pin / Report / Delete λ“± 선택
  MM-->>PU: onClose 호좜
  PU->>RI: closePopup()
  alt μ‹€νŒ¨/μ—λŸ¬
    RI->>PU: openSnackbar({ isError: true })
    PU-->>SB: μ—λŸ¬ μŠ€λ‚΅λ°” ν‘œμ‹œ
  end
Loading
sequenceDiagram
  autonumber
  participant U as User
  participant RF as RecordFilters
  participant OL as Overlay
  participant PRM as PageRangeModal

  U->>RF: νŽ˜μ΄μ§€ λ²”μœ„ μž…λ ₯ λͺ¨λ“œ μ§„μž…
  RF->>OL: 반투λͺ… μ˜€λ²„λ ˆμ΄ ν‘œμ‹œ
  U-->>PRM: μ‹œμž‘/끝 μž…λ ₯ (숫자 λ˜λŠ” 곡백)
  PRM->>PRM: 숫자 μœ νš¨μ„± 검사
  alt μ™ΈλΆ€ 클릭/μ·¨μ†Œ
    U->>OL: 클릭
    RF->>RF: μž…λ ₯κ°’ μ΄ˆκΈ°ν™”, λͺ¨λ“œ μ’…λ£Œ, onPageRangeClear()
  else 확인
    U->>RF: 확인 클릭
    RF->>RF: start<=end && μ–‘μˆ˜ 검사 ν›„ 적용
  end
Loading
sequenceDiagram
  autonumber
  participant U as User
  participant PRS as PageRangeSection
  participant TT as Tooltip

  U->>PRS: '총평' ν† κΈ€ 클릭
  alt readingProgress < 80
    PRS->>TT: λΉ¨κ°„ 툴팁 λ…ΈμΆœ(ν† κΈ€ λ―Έμˆ˜ν–‰)
  else κ°€λŠ₯
    PRS->>PRS: ν† κΈ€ μƒνƒœ λ³€κ²½
  end
  U->>PRS: Info μ•„μ΄μ½˜ 클릭
  PRS->>TT: 초둝 툴팁 λ…ΈμΆœ
Loading
sequenceDiagram
  autonumber
  participant U as User
  participant TW as TodayWords
  participant API as Messages API
  participant SB as Snackbar

  U->>TW: λ©”μ‹œμ§€ 전솑
  TW->>TW: 였늘 λ°œμ‹  수 계산(getTodayDateStrings)
  alt 일일 μ œν•œ 초과
    TW->>SB: isError=true ν† μŠ€νŠΈ
  else 성곡
    TW->>API: 전솑
    API-->>TW: 성곡 응닡
    TW->>TW: 졜초 λ©”μ‹œμ§€λ©΄ 성곡 ν† μŠ€νŠΈ, μƒνƒœ 리셋 및 슀크둀 맨 μ•„λž˜
  end
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

Suggested labels

🎨 Html&css

Suggested reviewers

  • ho0010
  • heeeeyong

Poem

λ°”λžŒ 검은 λ°”λ‹₯μ‹œνŠΈ 달그락 펼치고,
λ©”λͺ¨λ¦¬ μˆ²μ—” 잠금 μžŽμ‚¬κ·€κ°€ 솔솔 🌿
νˆ΄νŒμ€ λΉ¨κ°•μ΄ˆλ‘ 깑총 깑총 λ§ν•˜λ„€,
β€œμ˜€λŠ˜μ˜ ν•œλ§ˆλ””, 쑰심! ν•œ 발짝 더!”
ν† μŠ€νŠΈκ°€ 띡— μ—λŸ¬λ©΄ λΆ‰κ²Œ, 성곡은 살짝—
μ½”λ“œλ₯Ό κ°‰μ•„ λ‹€λ“¬λŠ” 토끼 λ°œμžκ΅­β€¦ πŸ‡

Tip

πŸ”Œ Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


πŸ“œ Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

πŸ’‘ Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 0e071c9 and 3d0c8b7.

β›” Files ignored due to path filters (1)
  • src/assets/memory/record-x.svg is excluded by !**/*.svg
πŸ“’ Files selected for processing (42)
  • src/components/common/CommentBottomSheet/GlobalCommentBottomSheet.styled.ts (1 hunks)
  • src/components/common/Modal/MoreMenu.tsx (4 hunks)
  • src/components/common/Modal/Snackbar.tsx (3 hunks)
  • src/components/creategroup/ActivityPeriodSection/ActivityPeriodSection.styled.ts (2 hunks)
  • src/components/creategroup/ActivityPeriodSection/ActivityPeriodSection.tsx (3 hunks)
  • src/components/creategroup/RoomInfoSection.styled.ts (3 hunks)
  • src/components/creategroup/RoomInfoSection.tsx (2 hunks)
  • src/components/createpost/PostContentSection.styled.ts (1 hunks)
  • src/components/createpost/PostContentSection.tsx (0 hunks)
  • src/components/group/CommentSection.styled.ts (1 hunks)
  • src/components/group/GroupBookSection.styled.ts (1 hunks)
  • src/components/group/GroupBookSection.tsx (1 hunks)
  • src/components/group/HotTopicSection.styled.ts (1 hunks)
  • src/components/group/MyGroupCard.tsx (1 hunks)
  • src/components/group/RecordSection.styled.ts (1 hunks)
  • src/components/group/RecordSection.tsx (1 hunks)
  • src/components/memory/MemoryContent/MemoryContent.styled.ts (1 hunks)
  • src/components/memory/MemoryContent/MemoryContent.tsx (2 hunks)
  • src/components/memory/MemoryContent/RecordList.styled.ts (1 hunks)
  • src/components/memory/MemoryContent/RecordList.tsx (1 hunks)
  • src/components/memory/PageRangeModal.styled.ts (1 hunks)
  • src/components/memory/PageRangeModal.tsx (2 hunks)
  • src/components/memory/RecordFilters/FilterButtons.styled.ts (1 hunks)
  • src/components/memory/RecordFilters/FilterButtons.tsx (1 hunks)
  • src/components/memory/RecordFilters/PageInputMode.styled.ts (1 hunks)
  • src/components/memory/RecordFilters/PageInputMode.tsx (2 hunks)
  • src/components/memory/RecordFilters/RecordFilters.tsx (4 hunks)
  • src/components/memory/RecordInfoMessage.tsx (1 hunks)
  • src/components/memory/RecordItem/PollRecord.tsx (3 hunks)
  • src/components/memory/RecordItem/RecordItem.tsx (11 hunks)
  • src/components/recordwrite/PageRangeSection.styled.ts (4 hunks)
  • src/components/recordwrite/PageRangeSection.tsx (5 hunks)
  • src/pages/group/CreateGroup.tsx (1 hunks)
  • src/pages/groupDetail/GroupDetail.styled.ts (1 hunks)
  • src/pages/groupDetail/ParticipatedGroupDetail.styled.ts (1 hunks)
  • src/pages/groupDetail/ParticipatedGroupDetail.tsx (2 hunks)
  • src/pages/memory/Memory.tsx (6 hunks)
  • src/pages/post/CreatePost.tsx (2 hunks)
  • src/pages/post/UpdatePost.tsx (2 hunks)
  • src/pages/today-words/TodayWords.tsx (6 hunks)
  • src/stores/usePopupStore.ts (1 hunks)
  • src/types/memory.ts (2 hunks)
✨ Finishing Touches
  • πŸ“ Generate Docstrings
πŸ§ͺ Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch qa/jihyeon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@heeeeyong heeeeyong added the 🐞 BugFix Something isn't working label Aug 20, 2025
@ljh130334 ljh130334 merged commit 5077cea into develop Aug 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 BugFix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants