Skip to content

develp branch 작업내용 머지 : develop -> main#176

Merged
heeeeyong merged 8 commits intomainfrom
develop
Aug 20, 2025
Merged

develp branch 작업내용 머지 : develop -> main#176
heeeeyong merged 8 commits intomainfrom
develop

Conversation

@heeeeyong
Copy link
Collaborator

@heeeeyong heeeeyong commented Aug 20, 2025

이하동일

Summary by CodeRabbit

  • New Features

    • 피드 초기 로딩 및 탭 전환 시 전체 화면 로딩 스피너를 표시하여 진행 상태를 명확히 제공
    • 마이페이지 프로필 조회에 로딩 스피너와 오류 메시지 추가
  • Bug Fixes

    • 팔로우 목록 초기 렌더 시 나타나던 깜빡임(임시 상태 표시) 감소
  • Refactor

    • 게시물 이미지 렌더링 구조 단순화로 DOM 깊이 축소
  • Chores

    • Open Graph 썸네일을 PNG에서 JPEG로 교체하여 링크 미리보기 개선

@vercel
Copy link

vercel bot commented Aug 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 20, 2025 9:39am

@coderabbitai
Copy link

coderabbitai bot commented Aug 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

  • Open Graph 이미지 메타 태그를 JPEG로 변경.
  • PostBody 이미지 감싸는 div 제거로 DOM 한 단계 축소.
  • FollowList 초기 로딩 상태를 true로 변경.
  • MyFeed에서 LoadingSpinner 제거(빈 프래그먼트로 대체).
  • Feed 페이지에 초기/탭 전환 로딩 관리와 스피너 게이트 추가.
  • Mypage에 프로필 로딩 스피너와 오류 분기 도입.

Changes

Cohort / File(s) Summary
OG 이미지 메타 태그
index.html
og:image를 thumbnail.png에서 thumbnail.jpeg로 변경.
PostBody 이미지 DOM 단순화
src/components/common/Post/PostBody.tsx
.imgContainer 래퍼 div 제거; 이미지들을 ImageContainer의 직속 자식으로 렌더.
팔로우 리스트 초기 로딩 변경
src/components/feed/FollowList.tsx
초기 loadingfalsetrue로 변경; 첫 렌더 시 비노출 후 데이터 수신 뒤 렌더.
MyFeed 로딩 표시 조정
src/components/feed/MyFeed.tsx
LoadingSpinner import/사용 제거; 로딩 분기에 빈 프래그먼트 출력.
Feed 탭/초기 로딩 오케스트레이션
src/pages/feed/Feed.tsx
tabLoading, initialLoading 도입; 탭 전환/초기 로딩을 await로 순차 처리, 로딩 중엔 전역 스피너 표시.
Mypage 프로필 로딩/에러 분기
src/pages/mypage/Mypage.tsx
로딩 상태와 LoadingSpinner 추가, try/catch/finally로 fetch 래핑, 로딩 후 null이면 에러 메시지 표시.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant FeedPage as Feed.tsx
  participant Auth as Token/Auth
  participant API as Feed API
  participant UI as LoadingSpinner

  User->>FeedPage: 방문/초기 로드
  FeedPage->>UI: show(initialLoading=true)
  FeedPage->>Auth: 토큰 대기 및 인증 확인
  alt 인증됨
    FeedPage->>API: 내 피드 또는 전체 피드 로드(await)
    API-->>FeedPage: 포스트/페이지네이션 응답
  else 비인증
    FeedPage->>API: 전체 피드 로드(await)
    API-->>FeedPage: 포스트 응답
  end
  FeedPage->>UI: hide(initialLoading=false)
  User->>FeedPage: 탭 전환 클릭
  FeedPage->>UI: show(tabLoading=true)
  FeedPage->>API: 선택 탭 데이터 로드(await)
  API-->>FeedPage: 응답
  FeedPage->>UI: hide(tabLoading=false)
Loading
sequenceDiagram
  autonumber
  actor User
  participant Mypage as Mypage.tsx
  participant API as Profile API
  participant UI as LoadingSpinner

  User->>Mypage: 페이지 진입
  Mypage->>UI: show(loading=true, "내 정보를 불러오는 중...")
  Mypage->>API: 프로필 요청
  API-->>Mypage: 프로필 데이터 또는 에러
  alt 성공
    Mypage->>UI: hide(loading=false)
    Mypage-->>User: 프로필 화면 렌더
  else 실패/프로필 null
    Mypage->>UI: hide(loading=false)
    Mypage-->>User: "프로필 정보를 불러올 수 없습니다." 표시
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

✨ Feature, 🎨 Html&css

Suggested reviewers

  • ljh130334

Poem

귀 쫑긋, 스피너 빙글—로딩의 춤을 춘다
탭을 톡, 데이터 척—순서대로 잘 맞춘다
사진들엔 포장 벗기고 담백하게 찰칵
마이페이지 살짝 떨며 “조금만 기다려!”
썸네일도 새 옷 갈아입고,
토끼는 깡총—“이제 화면이 더 또렷해졌지!” 🐰✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3c0f800 and 3eb0ad6.

⛔ Files ignored due to path filters (3)
  • public/assets/custom_favicon.png is excluded by !**/*.png
  • public/assets/thumbnail.jpeg is excluded by !**/*.jpeg
  • public/assets/thumbnail.png is excluded by !**/*.png
📒 Files selected for processing (6)
  • index.html (1 hunks)
  • src/components/common/Post/PostBody.tsx (1 hunks)
  • src/components/feed/FollowList.tsx (1 hunks)
  • src/components/feed/MyFeed.tsx (1 hunks)
  • src/pages/feed/Feed.tsx (4 hunks)
  • src/pages/mypage/Mypage.tsx (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@heeeeyong heeeeyong self-assigned this Aug 20, 2025
@heeeeyong heeeeyong added the 🌏 Deploy 배포 관련 label Aug 20, 2025
@heeeeyong heeeeyong merged commit 427a707 into main Aug 20, 2025
1 of 2 checks passed
heeeeyong added a commit that referenced this pull request Aug 20, 2025
Merge pull request #176 from THIP-TextHip/develop
@coderabbitai coderabbitai bot mentioned this pull request Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌏 Deploy 배포 관련

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants