Skip to content

fix: QA 1차 수정#173

Merged
ho0010 merged 31 commits intodevelopfrom
fix/QA-HJ
Aug 20, 2025
Merged

fix: QA 1차 수정#173
ho0010 merged 31 commits intodevelopfrom
fix/QA-HJ

Conversation

@ho0010
Copy link
Collaborator

@ho0010 ho0010 commented Aug 20, 2025

QA 사항에 따라 수정 진행했습니다.

https://separate-snowplow-d8b.notion.site/254b701eb0b8814a81fbe1a289ce8fd0?v=254b701eb0b881f894b5000cdf5d6c63&pvs=74

Summary by CodeRabbit

  • 신규 기능

    • 상단 카운팅 바 알림 추가 및 스낵바 자동 닫힘 지원
    • 캐러셀(내 모임, 모집중) 드래그 스크롤 지원
    • 그룹 카드에 잠금 오버레이(모집 종료 시) 및 카드 클릭 이동 추가
    • 그룹 상세에 확인 모달·알림 도입, 참여/취소/모집마감 플로우 개선
    • 완료 모임 모달에 닉네임 개인화 표시
  • UI/UX

    • 로딩 스피너 적용, 수동 검색 시 상단으로 스크롤
    • 최근 검색 삭제 후 목록 자동 갱신
    • 추천/상세에 도서 이미지·출판사 표시 개선, 마감 라벨 문구·색상 조정
    • 스낵바/오버레이 스타일 및 각 페이지 간격·타이포그래피 조정
    • 빈 상태 일러스트 및 안내 문구 개선

ho0010 added 30 commits August 19, 2025 23:38
@ho0010 ho0010 requested review from heeeeyong and ljh130334 August 20, 2025 08:17
@ho0010 ho0010 self-assigned this Aug 20, 2025
@ho0010 ho0010 added the 🐞 BugFix Something isn't working label Aug 20, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

팝업 시스템 확장(새 타입 ‘counting-bar’ 추가), GroupDetail 조작 흐름에 확인 모달/스낵바 도입, 다수 UI 컴포넌트 스타일·인터랙션 개선(드래그 캐러셀, 잠금 오버레이), 검색/그룹 화면 텍스트·레이아웃 조정, API 타입 변경(roomImageUrl→bookImageUrl, isPublic 추가, publisher/recruitEndDate 반영).

Changes

Cohort / File(s) Summary
API 타입 업데이트
src/api/books/getRecruitingRooms.ts, src/api/rooms/getRoomDetail.ts
RecruitingRoom에 isPublic:boolean 추가. RecommendRoom 및 RoomDetailResponse의 roomImageUrl를 bookImageUrl로 리네임, publisher/recruitEndDate 필드 사용.
팝업 시스템 확장
src/stores/usePopupStore.ts, src/components/common/Modal/PopupContainer.tsx, src/components/common/Modal/CountingBar.tsx, src/components/common/Modal/ConfirmModal.tsx, src/components/common/Modal/Snackbar.tsx
PopupType에 ‘counting-bar’ 추가, CountingBar 컴포넌트 신설 및 컨테이너 연동, snackbar 자동 닫기 추가, 스크롤 락 조건 조정, ConfirmModal 디스크 HTML 렌더링 전환, Snackbar 스타일/트랜지션 변경.
그룹 카드/캐러셀 및 모달 스타일
src/components/group/GroupCard.tsx, src/components/search/GroupSearchResult.tsx, src/components/group/RecruitingGroupCarousel.tsx, src/components/group/MyGroupBox.tsx, src/components/group/MyGroupCard.tsx, src/components/group/CompletedGroupModal.tsx, src/components/group/Modal.styles.ts, src/components/group/PasswordModal.tsx, src/components/group/MyGroupModal.tsx, src/components/search/MostSearchedBooks.tsx
GroupCard에 잠금 오버레이·isFirstCard/onClick 추가 및 마감 문구/색상 변경, 검색 결과에서 GroupCard 직접 사용·ref 전달, 캐러셀 드래그(마우스/터치) 추가, MyGroupBox 단일 항목 처리·빈 상태 UI 개선, MyGroupCard isMine 추가, CompletedGroupModal 닉네임 표시·화이트 오버레이, Overlay에 $whiteBg prop 추가, MyGroupModal deadLine 매핑 변경, 기타 스타일 미세조정.
그룹 상세 화면
src/pages/groupDetail/GroupDetail.tsx, src/pages/groupDetail/GroupDetail.styled.ts, src/pages/groupDetail/ParticipatedGroupDetail.tsx
확인 모달·스낵바 기반 조작 흐름(모집 종료/취소/가입 성공) 도입, 추천 방 매핑에 bookImageUrl/recruitEndDate 사용, 퍼블리셔 표시, 스타일 간격 조정, 뒤로가기 경로 고정(/group).
검색/도서 상세 화면
src/pages/groupSearch/GroupSearch.tsx, src/pages/search/Search.tsx, src/pages/searchBook/SearchBook.tsx, src/pages/searchBook/SearchBook.styled.ts, src/pages/searchBook/SearchBookGroup.tsx
최근 검색 새로고침 로직 추가 및 삭제 후 재조회, Overlay $whiteBg 적용, 수동 검색 시 상단 스크롤, SearchBook 로딩 스피너/카운팅바 팝업/저자·출판사 표기, 책 그룹 카드 클릭 이동·데이터 매핑 업데이트.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Page as Page (GroupDetail/SearchBook)
  participant Popup as usePopupStore
  participant Container as PopupContainer
  participant UI as CountingBar

  User->>Page: 특정 이벤트 발생
  Page->>Popup: openPopup('counting-bar', { message, duration, onClose })
  Popup-->>Container: popupType='counting-bar', props 전달
  Container->>UI: Mount CountingBar(props)
  UI-->>UI: duration 경과 → exit 애니메이션
  UI->>Popup: onClose()
  Popup-->>Container: closePopup() → 언마운트
Loading
sequenceDiagram
  autonumber
  actor Host as Host/Participant
  participant Detail as GroupDetail Page
  participant Popup as usePopupStore
  participant API as Server
  participant Router as Navigation

  Host->>Detail: 하단 버튼 클릭
  Detail->>Popup: openPopup('confirm-modal', { onConfirm })
  Host->>Popup: Confirm
  Popup-->>Detail: onConfirm 호출
  Detail->>API: PUT/POST (종료 or 취소)
  API-->>Detail: 성공 응답
  Detail->>Popup: openPopup('snackbar', { message })
  Detail->>Router: navigate(목적지)
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

Suggested labels

✨ Feature, 🎨 Html&css, 📬 API

Suggested reviewers

  • heeeeyong
  • ljh130334

Poem

(•̀ᴗ•́)و ̑̑ ᕱ⑅ᕱ
팝업은 톡, 바는 슉—별빛처럼 사라지고,
잠긴 표지 위에 달빛이 살포시.
토끼는 드래그하며 달려가네,
마감과 표지가 반짝이는 길.
“딸깍!” 하면 스낵바가 윙크—업데이트 완료!

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e9652b2 and cfb1dcf.

⛔ Files ignored due to path filters (3)
  • src/assets/books/bookCoverLarge.svg is excluded by !**/*.svg
  • src/assets/books/lockedBook.svg is excluded by !**/*.svg
  • src/assets/group/noneMyGroupCharacter.svg is excluded by !**/*.svg
📒 Files selected for processing (25)
  • src/api/books/getRecruitingRooms.ts (1 hunks)
  • src/api/rooms/getRoomDetail.ts (1 hunks)
  • src/components/common/Modal/ConfirmModal.tsx (1 hunks)
  • src/components/common/Modal/CountingBar.tsx (1 hunks)
  • src/components/common/Modal/PopupContainer.tsx (3 hunks)
  • src/components/common/Modal/Snackbar.tsx (2 hunks)
  • src/components/group/CompletedGroupModal.tsx (4 hunks)
  • src/components/group/GroupCard.tsx (6 hunks)
  • src/components/group/Modal.styles.ts (2 hunks)
  • src/components/group/MyGroupBox.tsx (5 hunks)
  • src/components/group/MyGroupCard.tsx (2 hunks)
  • src/components/group/MyGroupModal.tsx (1 hunks)
  • src/components/group/PasswordModal.tsx (1 hunks)
  • src/components/group/RecruitingGroupCarousel.tsx (1 hunks)
  • src/components/search/GroupSearchResult.tsx (1 hunks)
  • src/components/search/MostSearchedBooks.tsx (2 hunks)
  • src/pages/groupDetail/GroupDetail.styled.ts (2 hunks)
  • src/pages/groupDetail/GroupDetail.tsx (9 hunks)
  • src/pages/groupDetail/ParticipatedGroupDetail.tsx (1 hunks)
  • src/pages/groupSearch/GroupSearch.tsx (5 hunks)
  • src/pages/search/Search.tsx (2 hunks)
  • src/pages/searchBook/SearchBook.styled.ts (2 hunks)
  • src/pages/searchBook/SearchBook.tsx (4 hunks)
  • src/pages/searchBook/SearchBookGroup.tsx (2 hunks)
  • src/stores/usePopupStore.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/QA-HJ

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ho0010 ho0010 merged commit 4b2908b into develop Aug 20, 2025
2 of 3 checks passed
@vercel
Copy link

vercel bot commented Aug 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thip Ready Ready Preview Comment Aug 20, 2025 8:17am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 BugFix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant