Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. Walkthrough소셜 로그인 리다이렉트 후 토큰 처리 흐름을 재구성. 신규 API 헬퍼(setCookie, exchangeTempToken) 추가 및 auth index에 재노출. 기존 useOAuthToken 훅 삭제, useSocialLoginToken 훅 신설. Feed/Signup 페이지들은 새 훅으로 교체하고, URL의 loginTokenKey 처리 및 후속 네비게이션을 정리. Changes
Sequence Diagram(s)sequenceDiagram
participant B as Browser
participant R as App Router
participant H as useSocialLoginToken
participant A as Auth API
participant W as Window History
B->>R: 방문 (리다이렉트 후 URL?loginTokenKey=...)
R->>H: 훅 마운트
H->>H: loginTokenKey 파싱
alt 경로 === /signup
H->>A: POST /auth/set-cookie { loginTokenKey } (withCredentials)
A-->>H: 200 응답
H->>W: replaceState (loginTokenKey 제거)
else 기타 경로
H->>A: POST /auth/exchange-temp-token { loginTokenKey } (withCredentials)
A-->>H: 200 응답 (accessToken 포함)
H->>W: replaceState (loginTokenKey 제거)
opt 실패 시
H->>R: navigate("/")
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (8)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
이하동일
Summary by CodeRabbit
신기능
리팩터링