-
Notifications
You must be signed in to change notification settings - Fork 0
Chore/#25 package modify #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package konkuk.thip.attendanceCheck.adapter.in.web; | ||
|
|
||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @RestController | ||
| @RequiredArgsConstructor | ||
| public class AttendanceCheckCommandController { | ||
|
|
||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,10 @@ | ||||||
| package konkuk.thip.attendanceCheck.adapter.in.web; | ||||||
|
|
||||||
| import lombok.RequiredArgsConstructor; | ||||||
| import org.springframework.web.bind.annotation.RestController; | ||||||
|
|
||||||
| @RestController | ||||||
| @RequiredArgsConstructor | ||||||
| public class AttendanceCheckQuerydController { | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 클래스명 오타 수정 필요 클래스명에 오타가 있습니다. -public class AttendanceCheckQuerydController {
+public class AttendanceCheckQueryController {📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| } | ||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,7 @@ | ||||||||||||||||||||||||||||||||||||
| package konkuk.thip.attendanceCheck.adapter.in.web.request; | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| import lombok.Getter; | ||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||
| @Getter | ||||||||||||||||||||||||||||||||||||
| public class UserSignupRequest { | ||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||
|
Comment on lines
+5
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 빈 DTO는 의미가 없습니다 @Getter
-public class UserSignupRequest {
-}
+@NoArgsConstructor(access = AccessLevel.PROTECTED)
+@AllArgsConstructor
+@Builder
+public class UserSignupRequest {
+ @NotBlank
+ private String email;
+
+ @NotBlank
+ private String password;
+
+ @NotBlank
+ private String nickname;
+}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package konkuk.thip.attendanceCheck.adapter.in.web.response; | ||
|
|
||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| public class DummyResponse { | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,15 @@ | ||||||||||||||||||||
| package konkuk.thip.attendanceCheck.adapter.out.persistence; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| import konkuk.thip.attendanceCheck.adapter.out.mapper.AttendanceCheckMapper; | ||||||||||||||||||||
| import konkuk.thip.attendanceCheck.application.port.out.AttendanceCheckCommandPort; | ||||||||||||||||||||
| import lombok.RequiredArgsConstructor; | ||||||||||||||||||||
| import org.springframework.stereotype.Repository; | ||||||||||||||||||||
|
Comment on lines
+3
to
+6
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 필수: 누락된 import 문을 추가해야 합니다.
다음 import 문을 추가해주세요: import konkuk.thip.attendanceCheck.adapter.out.mapper.AttendanceCheckMapper;
import konkuk.thip.attendanceCheck.application.port.out.AttendanceCheckCommandPort;
+import konkuk.thip.attendanceCheck.adapter.out.persistence.AttendanceCheckRepository;
import lombok.RequiredArgsConstructor;📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||
|
|
||||||||||||||||||||
| @Repository | ||||||||||||||||||||
| @RequiredArgsConstructor | ||||||||||||||||||||
| public class AttendanceCheckCommandPersistenceAdapter implements AttendanceCheckCommandPort { | ||||||||||||||||||||
|
|
||||||||||||||||||||
| private final AttendanceCheckRepository attendanceCheckRepository; | ||||||||||||||||||||
| private final AttendanceCheckMapper attendanceCheckMapper; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| } | ||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,15 @@ | ||||||||
| package konkuk.thip.attendanceCheck.adapter.out.persistence; | ||||||||
|
|
||||||||
| import konkuk.thip.attendanceCheck.adapter.out.mapper.AttendanceCheckMapper; | ||||||||
| import konkuk.thip.attendanceCheck.application.port.out.AttendnaceCheckQueryPort; | ||||||||
| import lombok.RequiredArgsConstructor; | ||||||||
| import org.springframework.stereotype.Repository; | ||||||||
|
|
||||||||
| @Repository | ||||||||
| @RequiredArgsConstructor | ||||||||
| public class AttendanceCheckQueryPersistenceAdapter implements AttendnaceCheckQueryPort { | ||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 인터페이스명 오타 수정 필요 구현하고 있는 인터페이스명에 오타가 있습니다. -public class AttendanceCheckQueryPersistenceAdapter implements AttendnaceCheckQueryPort {
+public class AttendanceCheckQueryPersistenceAdapter implements AttendanceCheckQueryPort {📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||
|
|
||||||||
| private final AttendanceCheckRepository jpaRepository; | ||||||||
| private final AttendanceCheckMapper attendanceCheckMapper; | ||||||||
|
|
||||||||
| } | ||||||||
|
Comment on lines
+8
to
+15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion 빈 어댑터 구현 완성 필요 현재 퍼시스턴스 어댑터가 빈 상태입니다. 인터페이스의 메소드들을 구현하거나, 향후 구현 예정이라면 TODO 주석을 추가하는 것을 권장합니다. 🤖 Prompt for AI Agents |
||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package konkuk.thip.attendanceCheck.adapter.out.persistence; | ||
|
|
||
| import konkuk.thip.attendanceCheck.adapter.out.jpa.AttendanceCheckJpaEntity; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface AttendanceCheckRepository extends JpaRepository<AttendanceCheckJpaEntity, Long> { | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package konkuk.thip.attendanceCheck.application.port.in; | ||
|
|
||
| public interface DummyUseCase { | ||
|
|
||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package konkuk.thip.attendanceCheck.application.port.in.dto; | ||
|
|
||
| import lombok.Builder; | ||
| import lombok.Getter; | ||
|
|
||
| @Builder | ||
| @Getter | ||
| public class DummyCommand { | ||
|
|
||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package konkuk.thip.attendanceCheck.application.port.in.dto; | ||
|
|
||
| import lombok.Builder; | ||
| import lombok.Getter; | ||
|
|
||
| @Builder | ||
| @Getter | ||
| public class DummyQuery { | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package konkuk.thip.attendanceCheck.application.port.in.dto; | ||
|
|
||
| import lombok.Builder; | ||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| @Builder | ||
| public class DummyResult { | ||
|
|
||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package konkuk.thip.attendanceCheck.application.port.out; | ||
|
|
||
|
|
||
| public interface AttendanceCheckCommandPort { | ||
|
|
||
| } |
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,5 @@ | ||||||||||||||||
| package konkuk.thip.attendanceCheck.application.port.out; | ||||||||||||||||
|
|
||||||||||||||||
| public interface AttendnaceCheckQueryPort { | ||||||||||||||||
|
Comment on lines
+1
to
+3
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 타이핑 오류: 파일명·패키지 경로·인터페이스 명칭 모두 오탈자입니다. 오탈자는 컴파일 오류 및 IDE 검색 실패를 야기하므로 즉시 수정이 필요합니다. -package konkuk.thip.attendanceCheck.application.port.out;
-
-public interface AttendnaceCheckQueryPort {
+package konkuk.thip.attendanceCheck.application.port.out;
+
+public interface AttendanceCheckQueryPort {
}또한 구현체( 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||
|
|
||||||||||||||||
| } | ||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package konkuk.thip.attendanceCheck.application.service; | ||
|
|
||
| import konkuk.thip.attendanceCheck.application.port.in.DummyUseCase; | ||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.stereotype.Service; | ||
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class AttendanceCheckService implements DummyUseCase { | ||
|
|
||
| } | ||
|
Comment on lines
+7
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion 빈 서비스 클래스 구현 완성 필요 현재 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package konkuk.thip.notification.adapter.in.web; | ||
|
|
||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @RestController | ||
| @RequiredArgsConstructor | ||
| public class NotificationCommandController { | ||
|
|
||
| } | ||
|
Comment on lines
+6
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Command용 엔드포인트 정의 필요 Query 컨트롤러와 동일하게, 실제 커맨드(등록·수정·삭제 등)를 처리할 메서드가 없습니다. 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package konkuk.thip.notification.adapter.in.web; | ||
|
|
||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @RestController | ||
| @RequiredArgsConstructor | ||
| public class NotificationQueryController { | ||
|
|
||
| } | ||
|
Comment on lines
+6
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion 매핑 정보가 없는 Controller
🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package konkuk.thip.notification.adapter.in.web.request; | ||
|
|
||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| public class UserSignupRequest { | ||
| } | ||
|
Comment on lines
+5
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion ❓ Verification inconclusive빈 DTO 클래스로는 실질적 요청 데이터 전달이 어려움
빈 DTO 클래스로는 실질적 요청 데이터 전달이 어려움
🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package konkuk.thip.notification.adapter.in.web.response; | ||
|
|
||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| public class DummyResponse { | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package konkuk.thip.notification.adapter.out.persistence; | ||
|
|
||
| import konkuk.thip.notification.adapter.out.mapper.NotificationMapper; | ||
| import konkuk.thip.notification.application.port.out.NotificationCommandPort; | ||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.stereotype.Repository; | ||
|
|
||
| @Repository | ||
| @RequiredArgsConstructor | ||
| public class NotificationCommandPersistenceAdapter implements NotificationCommandPort { | ||
|
|
||
| private final NotificationJpaRepository notificationJpaRepository; | ||
| private final NotificationMapper notificationMapper; | ||
|
|
||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package konkuk.thip.notification.adapter.out.persistence; | ||
|
|
||
| import konkuk.thip.notification.adapter.out.jpa.NotificationJpaEntity; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface NotificationJpaRepository extends JpaRepository<NotificationJpaEntity, Long> { | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,15 @@ | ||||||
| package konkuk.thip.notification.adapter.out.persistence; | ||||||
|
|
||||||
| import konkuk.thip.notification.adapter.out.mapper.NotificationMapper; | ||||||
| import konkuk.thip.notification.application.port.out.NotificationQueryPort; | ||||||
| import lombok.RequiredArgsConstructor; | ||||||
| import org.springframework.stereotype.Repository; | ||||||
|
|
||||||
| @Repository | ||||||
| @RequiredArgsConstructor | ||||||
| public class NotificationQueryPersistenceAdapter implements NotificationQueryPort { | ||||||
|
|
||||||
| private final NotificationJpaRepository jpaRepository; | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion 필드명 일관성 문제
다음과 같이 수정하는 것을 권장합니다: - private final NotificationJpaRepository jpaRepository;
+ private final NotificationJpaRepository notificationJpaRepository;📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| private final NotificationMapper notificationMapper; | ||||||
|
|
||||||
| } | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package konkuk.thip.notification.application.port.in; | ||
|
|
||
| public interface DummyUseCase { | ||
|
|
||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package konkuk.thip.notification.application.port.in.dto; | ||
|
|
||
| import lombok.Builder; | ||
| import lombok.Getter; | ||
|
|
||
| @Builder | ||
| @Getter | ||
| public class DummyCommand { | ||
|
|
||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package konkuk.thip.notification.application.port.in.dto; | ||
|
|
||
| import lombok.Builder; | ||
| import lombok.Getter; | ||
|
|
||
| @Builder | ||
| @Getter | ||
| public class DummyQuery { | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package konkuk.thip.notification.application.port.in.dto; | ||
|
|
||
| import lombok.Builder; | ||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| @Builder | ||
| public class DummyResult { | ||
|
|
||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package konkuk.thip.notification.application.port.out; | ||
|
|
||
|
|
||
| public interface NotificationCommandPort { | ||
|
|
||
| } | ||
|
Comment on lines
+4
to
+6
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Port 인터페이스에 계약(메서드)을 정의하세요
🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package konkuk.thip.notification.application.port.out; | ||
|
|
||
| public interface NotificationQueryPort { | ||
|
|
||
| } | ||
|
Comment on lines
+3
to
+5
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion ❓ Verification inconclusive빈 인터페이스만 존재 – 계약(Contract) 정의가 필요합니다 아직 쿼리용 메서드 시그니처가 전혀 없어서, 실제 어댑터·서비스 계층과의 계약이 명확하지 않습니다. 최소한 예상되는 조회 기능(예: 빈 인터페이스만 존재 – 계약(Contract) 정의가 필요합니다 아직 쿼리용 메서드 시그니처가 전혀 없어서, 실제 어댑터·서비스 계층과의 계약이 명확하지 않습니다. 최소한 예상되는 조회 기능(예: 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package konkuk.thip.notification.application.service; | ||
|
|
||
| import konkuk.thip.notification.application.port.in.DummyUseCase; | ||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.stereotype.Service; | ||
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class NotificationService implements DummyUseCase { | ||
|
|
||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
빈 컨트롤러 클래스 구현 완성 필요
현재
AttendanceCheckCommandController는 빈 상태입니다. 기본적인 엔드포인트 구조를 추가하거나, 향후 구현 예정이라면 TODO 주석을 추가하는 것을 권장합니다.🤖 Prompt for AI Agents