Skip to content

[Hotfix] 방 조회 관련 api들 공개방 반환/ isPublic 반환 필드 추가 #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hd0rable merged 2 commits into from
Aug 18, 2025
Merged

[Hotfix] 방 조회 관련 api들 공개방 반환/ isPublic 반환 필드 추가 #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaf51f4
[hotfix] 특정 책으로 모집중인 방 조회 isPublic response 반환하도록 수정 (#258)
hd0rable Aug 18, 2025
13c4fe7
[hotfix] 이런방은 어때요? 모임방 추천시 공개방만 반환하도록 수정 (#258)
hd0rable Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/konkuk/thip/book/adapter/in/web/response/BookRecruitingRoomsResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ public record BookRecruitingRoomDto(
String roomName,
int memberCount,
int recruitCount,
String deadlineEndDate
String deadlineEndDate,
boolean isPublic
) {
}
}
6 changes: 4 additions & 2 deletions ...ain/java/konkuk/thip/room/adapter/out/persistence/repository/RoomQueryRepositoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ public List<RoomRecruitingDetailViewResponse.RecommendRoom> findOtherRecruitingR
.where(
room.categoryJpaEntity.value.eq(category)
.and(room.startDate.after(LocalDate.now())) // 모집 마감 시각 > 현재 시각
.and(room.roomId.ne(roomId)) // 현재 방 제외
.and(room.roomId.ne(roomId))// 현재 방 제외
.and(room.isPublic.isTrue()) // 공개방 만
Copy link
Collaborator

@seongjunnoh seongjunnoh Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다

Copy link
Member Author

@hd0rable hd0rable Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어깜작아 넼ㅋㅋㅋ

)
.groupBy(room.roomId, room.title, room.recruitCount, room.startDate)
.orderBy(room.startDate.asc())
Expand Down Expand Up @@ -413,7 +414,8 @@ public List<RoomQueryDto> findRoomsByIsbnOrderByStartDateAsc(String isbn, LocalD
room.title,
room.recruitCount,
room.memberCount,
cursorExpr
cursorExpr,
room.isPublic
))
.from(room)
.join(room.bookJpaEntity, book)
Expand Down