Skip to content

[hotfix] response 필드 네이밍 통일 #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seongjunnoh merged 2 commits into from
Aug 12, 2025
Merged

[hotfix] response 필드 네이밍 통일 #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b35321e
[fix] response 에 남아있는 alias -> aliasName 로 수정 (#200)
seongjunnoh Aug 12, 2025
2a5959d
[fix] 테스트 코드 수정 (#200)
seongjunnoh Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/konkuk/thip/comment/adapter/in/web/response/CommentForSinglePostResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public record RootCommentDto(
Long creatorId,
String creatorProfileImageUrl,
String creatorNickname,
String alias,
String aliasName,
String aliasColor,
String postDate, // 댓글 작성 시각 (~ 전 형식)
String content,
Expand All @@ -27,7 +27,7 @@ public record ReplyDto(
Long creatorId,
String creatorProfileImageUrl,
String creatorNickname,
String alias,
String aliasName,
String aliasColor,
String postDate, // 댓글 작성 시각 (~ 전 형식)
String content,
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/konkuk/thip/comment/application/mapper/CommentQueryMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,15 @@ public interface CommentQueryMapper {
@Mapping(target = "isLike", expression = "java(likedCommentIds.contains(root.commentId()))")
@Mapping(target = "isDeleted", constant = "false")
@Mapping(target = "postDate", expression = "java(DateUtil.formatBeforeTime(root.createdAt()))")
CommentForSinglePostResponse.RootCommentDto toRoot(CommentQueryDto root,
@Context Set<Long> likedCommentIds);
@Mapping(target = "aliasName", source = "root.alias")
CommentForSinglePostResponse.RootCommentDto toRoot(CommentQueryDto root, @Context Set<Long> likedCommentIds);

/**
* 개별 답글 매핑
*/
@Mapping(target = "isLike", expression = "java(likedCommentIds.contains(child.commentId()))")
@Mapping(target = "postDate", expression = "java(DateUtil.formatBeforeTime(child.createdAt()))")
@Mapping(target = "aliasName", source = "child.alias")
CommentForSinglePostResponse.RootCommentDto.ReplyDto toReply(CommentQueryDto child, @Context Set<Long> likedCommentIds);

/**
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/konkuk/thip/room/adapter/in/web/response/RoomGetMemberListResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public record MemberSearchResult(
Long userId,
String nickname,
String imageUrl,
String alias,
String aliasName,
int followerCount
) {}
}
2 changes: 1 addition & 1 deletion src/main/java/konkuk/thip/room/application/service/RoomGetMemberListService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public RoomGetMemberListResponse getRoomMemberList(Long roomId) {
.userId(userId)
.nickname(user.getNickname())
.imageUrl(user.getAlias().getImageUrl())
.alias(user.getAlias().getValue())
.aliasName(user.getAlias().getValue())
.followerCount(user.getFollowerCount())
.build();
})
Expand Down
6 changes: 3 additions & 3 deletions src/test/java/konkuk/thip/room/adapter/in/web/RoomGetMemberListApiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,17 +151,17 @@ void getRoomMemberList_success() throws Exception {
.andExpect(jsonPath("$.data.userList[0].userId").value(user1.getUserId().intValue()))
.andExpect(jsonPath("$.data.userList[0].nickname").exists())
.andExpect(jsonPath("$.data.userList[0].imageUrl").exists())
.andExpect(jsonPath("$.data.userList[0].alias").exists())
.andExpect(jsonPath("$.data.userList[0].aliasName").exists())
.andExpect(jsonPath("$.data.userList[0].followerCount").isNumber())
.andExpect(jsonPath("$.data.userList[1].userId").value(user2.getUserId().intValue()))
.andExpect(jsonPath("$.data.userList[1].nickname").exists())
.andExpect(jsonPath("$.data.userList[1].imageUrl").exists())
.andExpect(jsonPath("$.data.userList[1].alias").exists())
.andExpect(jsonPath("$.data.userList[1].aliasName").exists())
.andExpect(jsonPath("$.data.userList[1].followerCount").isNumber())
.andExpect(jsonPath("$.data.userList[2].userId").value(user3.getUserId().intValue()))
.andExpect(jsonPath("$.data.userList[2].nickname").exists())
.andExpect(jsonPath("$.data.userList[2].imageUrl").exists())
.andExpect(jsonPath("$.data.userList[2].alias").exists())
.andExpect(jsonPath("$.data.userList[2].aliasName").exists())
.andExpect(jsonPath("$.data.userList[2].followerCount").isNumber());
}

Expand Down