[hotfix] 내 방 목록 조회, 모집중인 모임방 상세조회 api response 추가 수정#158
Merged
seongjunnoh merged 2 commits intodevelopfrom Aug 6, 2025
Merged
Conversation
2 tasks
WalkthroughRoom 관련 API 응답 객체에 필드가 추가되었습니다. 내 모임방 목록 조회 응답에 모집 인원 및 현재 인원 필드가 추가되고, 모집중인 방 상세보기 응답의 추천 방 객체에 roomId가 포함되었습니다. 또한, 해당 roomId가 쿼리 결과에서 올바르게 할당되도록 쿼리 리포지토리 구현이 수정되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Controller
participant Repository
Client->>Controller: 내 모임방 목록 조회 API 요청
Controller->>Repository: 방 목록 조회 쿼리
Repository-->>Controller: recruitCount, memberCount 포함된 방 목록 반환
Controller-->>Client: recruitCount, memberCount 포함 응답 반환
Client->>Controller: 모집중인 방 상세보기 API 요청
Controller->>Repository: 추천 방 목록 쿼리
Repository-->>Controller: roomId 포함된 추천 방 목록 반환
Controller-->>Client: roomId 포함된 추천 방 응답 반환
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Assessment against linked issues
Suggested labels
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
seongjunnoh
deleted the
hotfix/#157/room-show-mine-and-show-recruiting-room-response-fix
branch
This was referenced Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
157 번 이슈 참고하시면 됩니다
📸 스크린샷
response에 recruitingCount 추가하였습니다
resposne에 추천방의 roomId 값 추가하였습니다
💬 리뷰 요구사항
📌 PR 진행 시 이러한 점들을 참고해 주세요
Summary by CodeRabbit