[UI] top app bar 컴포넌트 구현완료#28
Merged
Nico1eKim merged 9 commits intoTHIP-TextHip:developfrom Jun 26, 2025
Merged
Conversation
Nico1eKim
requested review from
JJUYAAA and
rbqks529
and removed request for
JJUYAAA
|
Caution Review failedThe pull request is closed. """ Walkthrough여러 종류의 Top App Bar UI 컴포넌트(Book, Default, Input, FeedList, Logo, LeftName)가 Jetpack Compose로 신규 구현되었습니다. 각 컴포넌트는 커스터마이즈 가능한 파라미터와 프리뷰를 포함합니다. 버튼 컴포저블의 인터페이스가 개선되었고, 문자열 및 벡터 리소스가 추가/수정되었습니다. 일부 IDE 설정 파일이 정리되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TopAppBar (Composable)
participant Callback
User->>TopAppBar: 파라미터 전달 (타입별, 클릭 핸들러 등)
TopAppBar->>User: UI 렌더링 (타입별 커스텀)
User->>TopAppBar: 아이콘/버튼 클릭
TopAppBar->>Callback: onLeftClick(), onRightClick() 등 호출
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (10)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
rbqks529
reviewed
Jun 30, 2025
Collaborator
rbqks529
left a comment
rbqks529
left a comment
There was a problem hiding this comment.
TopAppBar 전부 확인했는데 최대한 범용성있게 다 파라미터로 넣어서 처리한거 보니까 고수의 냄새가 나네요 현재 개발한거에 pull해서 처리한 후에 개발하신 TopAppBar로 바꿔서 처리하겠습니다 고생하셨어
JJUYAAA
reviewed
Jul 1, 2025
| isLeftIconVisible: Boolean = false, | ||
| isRightIconVisible: Boolean = false, | ||
| leftIcon: Painter, | ||
| rightIcon: Painter, |
Member
There was a problem hiding this comment.
leftIcon이랑 rightIcon을 nullable로 처리하지 않고 isLeftIconVisible 같은 Boolean 값을 별도로 두셔서 아이콘 없이 사용하는 경우에도 아이콘을 입력해야하는게 좀 비효율적이지 않나 싶은데, 이렇게 구현하신 이유가 따로 있는지 궁금합니다!
Member
Author
There was a problem hiding this comment.
아 이거 처음에 저 두개 아이콘이 변경 가능한지 모르고 구현했다가 나중에 수정해서 아마 저렇게 남아있는건데 지금 수정한 코드에서는 아이콘도 기본으로 적용되게 해놔서 아마 괜찮을 것 같습니다 ..!
This was referenced Jul 9, 2025
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
➕ 이슈 링크
🔎 작업 내용
📸 스크린샷
type = book -> BookTopAppBar
type = default -> DefaultTopAppBar
type = inputpage -> InputTopAppBar
type = feed_list -> FeedListTopAppBar
type = logo -> LogoTopAppBar
type = left_name -> LeftNameTopAppBar
😢 해결하지 못한 과제
[] TASK
📢 리뷰어들에게
Summary by CodeRabbit
신규 기능
개선 사항
문서 및 리소스