-
Notifications
You must be signed in to change notification settings - Fork 3
[API] 기록장 기록, 투표 수정 #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Nico1eKim
merged 11 commits into
THIP-TextHip:develop
from
Nico1eKim:api/#133-group_note_edit
Sep 11, 2025
Merged
[API] 기록장 기록, 투표 수정 #134
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
326ade0
[feat]: 기록 수정 data layer 작성 (#133)
Nico1eKim 2a33113
[feat]: 기록 수정 viewmodel 작성 (#133)
Nico1eKim bbfef89
[feat]: 기록 수정 api 연결 로직 작성 (#133)
Nico1eKim cfe3a7c
[feat]: 기록 수정 navigation 연결 (#133)
Nico1eKim 8ba2ed5
[feat]: 투표 수정 data layer 작성 (#133)
Nico1eKim e0bb7cc
[feat]: 수정 메뉴 분기처리 (#133)
Nico1eKim 0175a47
[feat]: 투표 수정 navigation 연결 (#133)
Nico1eKim f94ccec
[feat]: 투표 수정 viewmodel 작성 (#133)
Nico1eKim 77d0f7c
[feat]: 투표 수정 api 연결 로직 작성 (#133)
Nico1eKim 299ec7e
[ui]: 기록장 화면 ui 잘리는 문제 해결 (#133)
Nico1eKim 5b0c1ae
[feat]: 수정화면으로 넘어갈 때 cursor 맨 뒤에 focus 잡히게 구현 (#133)
Nico1eKim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
app/src/main/java/com/texthip/thip/data/model/rooms/request/RoomsPatchRecordRequest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package com.texthip.thip.data.model.rooms.request | ||
|
|
||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class RoomsPatchRecordRequest( | ||
| val content: String | ||
| ) |
8 changes: 8 additions & 0 deletions
8
app/src/main/java/com/texthip/thip/data/model/rooms/request/RoomsPatchVoteRequest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package com.texthip.thip.data.model.rooms.request | ||
|
|
||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class RoomsPatchVoteRequest( | ||
| val content: String, | ||
| ) |
8 changes: 8 additions & 0 deletions
8
app/src/main/java/com/texthip/thip/data/model/rooms/response/RoomsPatchRecordResponse.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package com.texthip.thip.data.model.rooms.response | ||
|
|
||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class RoomsPatchRecordResponse( | ||
| val roomId: Int | ||
| ) |
8 changes: 8 additions & 0 deletions
8
app/src/main/java/com/texthip/thip/data/model/rooms/response/RoomsPatchVoteResponse.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package com.texthip.thip.data.model.rooms.response | ||
|
|
||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class RoomsPatchVoteResponse( | ||
| val roomId: Int, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
vote PATCH 경로/ID 매핑 재확인 필요
서비스는
"rooms/{roomId}/votes/{voteId}"(복수형) 경로를 사용합니다. 기존 POST/DELETE는 단수형vote를 사용 중이라 404 위험이 있습니다. 또한 UI에서 전달하는postId가 실제voteId와 동일한지 확인이 필요합니다.아래 스크립트로 현재 경로 일관성을 점검해 주세요:
🏁 Script executed:
Length of output: 55050
RoomsService POST/DELETE 경로 plural 통일 및 voteId 매핑 검증
@POST("rooms/{roomId}/vote/{voteId}")/@DELETE("rooms/{roomId}/vote/{voteId}")→@POST("rooms/{roomId}/votes/{voteId}")/@DELETE("rooms/{roomId}/votes/{voteId}")로 변경postId가 백엔드의voteId와 일치하는 값인지 재확인 필요🤖 Prompt for AI Agents