-
Notifications
You must be signed in to change notification settings - Fork 3
[REFACTOR] QA 4차 수정 #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[REFACTOR] QA 4차 수정 #123
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
d2d109a
[refactor]: 탭 다시 선택했을 때 스크롤 최상단 (#102)
rbqks529 7da1a0a
Merge branch 'THIP-TextHip:develop' into refactor/#102_QA_4
rbqks529 09882e4
[refactor]: 닉네임으로 대문자 입력을 하지 못하게 수정 (#102)
rbqks529 0a3aa0f
[refactor]: 해당 textField를 Basic으로 구현(패딩 문제) (#102)
rbqks529 68e7b13
[refactor]: Screen에서 Content로 미구현된 부분을 Content로 수정 (#102)
rbqks529 21a3227
[refactor]: Screen에서 Content로 미구현된 부분을 Content로 수정 (#102)
rbqks529 a26da57
[refactor]: MyPageSave에서 저장된 피드와 책을 눌렀을 때 자세히 보기 화면으로 이동 로직 추가 (#102)
rbqks529 fce906c
[refactor]: 자동으로 소문자 변환 (#102)
rbqks529 8d82438
[refactor]: 사진 더보기 화면 아이콘 위치 수정 (#102)
rbqks529 b38efa3
[refactor]: 피드 게시글 페이지 사용자 칭호별 색 반영 (#102)
rbqks529 b0fe3da
[refactor]: 사용자 검색 시 사용자 칭호별 색 반영 (#102)
rbqks529 75008af
[refactor]: 피드 관련 QA 수정(닉네임 수정, 다른 유저 게시글 좋아요) (#102)
rbqks529 72d1ec5
[refactor]: 피드 관련 QA 수정(닉네임 수정, 다른 유저 게시글 좋아요) (#102)
rbqks529 f92b0e4
[refactor]: 책 조회 api cursor 기반으로 수정 (#102)
rbqks529 421e3a6
[refactor]: 모임 및 피드 생성시 책검색 무한 스크롤 로직 되도록 수정 (#102)
rbqks529 bd017ca
[refactor]: 책 조회 api cursor 기반으로 수정 (#102)
rbqks529 ef29f58
[refactor]: 참여중인 모임방 조회 api cursor 기반으로 수정 (#102)
rbqks529 a4645b1
[refactor]: 책 조회 api cursor 기반으로 수정 (#102)
rbqks529 e88aa37
[refactor]: 참여중인 모임방 dto 수정 (#102)
rbqks529 8388234
[refactor]: 이미지 업로드 방식 수정을 위한 dto수정 (#102)
rbqks529 7c67d8f
[refactor]: 이미지 업로드 헬퍼 구현 (#102)
rbqks529 2542073
[refactor]: 이미지 업로드 수정된 버전으로 구현 (#102)
rbqks529 926e777
[refactor]: 이미지 업로드 request 로직 수정 (#102)
rbqks529 8947228
[refactor]: 이미지 업로드 request 로직 수정 (#102)
rbqks529 c171e22
[refactor]: QA 반영 띄어쓰기 및 dp 수정 (#102)
rbqks529 eb16b28
[refactor]: QA 반영 기록장 text field 수정 (#102)
rbqks529 eab3e5c
[refactor]: QA 반영 모집중인 모임방 버튼 비활성화 및 토스트 메세지 표시 (#102)
rbqks529 ce65cad
[refactor]: QA 반영 프로필 이미지 테두리 적용 (#102)
rbqks529 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 4 additions & 1 deletion
5
app/src/main/java/com/texthip/thip/data/model/book/response/BookUserSaveResponse.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
app/src/main/java/com/texthip/thip/data/model/feed/request/PresignedUrlRequest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package com.texthip.thip.data.model.feed.request | ||
|
|
||
| import kotlinx.serialization.SerialName | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class ImageMetadata( | ||
| @SerialName("extension") | ||
| val extension: String, | ||
| @SerialName("size") | ||
| val size: Long | ||
| ) | ||
|
|
||
| typealias PresignedUrlRequest = List<ImageMetadata> |
18 changes: 18 additions & 0 deletions
18
app/src/main/java/com/texthip/thip/data/model/feed/response/PresignedUrlResponse.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package com.texthip.thip.data.model.feed.response | ||
|
|
||
| import kotlinx.serialization.SerialName | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class PresignedUrlInfo( | ||
| @SerialName("presignedUrl") | ||
| val presignedUrl: String, | ||
| @SerialName("fileUrl") | ||
| val fileUrl: String | ||
| ) | ||
|
|
||
| @Serializable | ||
| data class PresignedUrlResponse( | ||
| @SerialName("presignedUrls") | ||
| val presignedUrls: List<PresignedUrlInfo> | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
커서 기반 필드 도입 OK, 사용처 점검 필요
nextCursor추가는 적절합니다. 다만last/first와 동시 노출 시 어떤 값을 진리 소스로 삼을지 명확히 하세요(권장: 한쪽만 UI 판단 근거).서비스/레포지토리 시그니처가 커서 파라미터를 수용하는지 점검:
🏁 Script executed:
Length of output: 1528
커서 기반 페이징 UI 진리 소스 결정 필요
cursor파라미터 수용은 이미 완료되어 있습니다.🤖 Prompt for AI Agents